Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve FunctionMesh labels #451

Merged
merged 2 commits into from
Aug 22, 2022
Merged

improve FunctionMesh labels #451

merged 2 commits into from
Aug 22, 2022

Conversation

tpiperatgod
Copy link
Contributor

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #449

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Current labels:

    "app":       AppFunctionMesh,
    "component": ComponentFunction,
    "name":      function.Name,
    "namespace": function.Namespace,

New labels:

    "app.kubernetes.io/name":            jobName, // <resource name> + "-function"
    "app.kubernetes.io/instance":        jobName,
    "compute.functionmesh.io/app":       AppFunctionMesh,
    "compute.functionmesh.io/component": ComponentFunction,
    "compute.functionmesh.io/name":      function.Name,
    "compute.functionmesh.io/namespace": function.Namespace,
    // The following will be deprecated after two releases
    "app":       AppFunctionMesh,
    "component": ComponentFunction,
    "name":      function.Name,
    "namespace": function.Namespace,

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@tpiperatgod tpiperatgod requested review from nlu90, freeznet and a team as code owners August 18, 2022 02:43
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Aug 18, 2022
Signed-off-by: laminar <tpiperatgod@gmail.com>
Signed-off-by: laminar <tpiperatgod@gmail.com>
@freeznet freeznet added type/enhancement Indicates an improvement to an existing feature component/controller m/2022-09 labels Aug 22, 2022
@nlu90 nlu90 merged commit d81ed4c into streamnative:master Aug 22, 2022
@nlu90 nlu90 added this to the 2022-09 v0.6.0 milestone Aug 22, 2022
@nlu90
Copy link
Contributor

nlu90 commented Aug 22, 2022

We may need to make a release for this PR to unblock some internal projects

@tpiperatgod tpiperatgod deleted the issue-449 branch August 23, 2022 00:59
@freeznet freeznet removed this from the 2022-09 v0.6.0 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/controller m/2022-09 no-need-doc This pr does not need any document type/enhancement Indicates an improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Function Mesh Labels
4 participants