Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed function create npe #109

Merged
merged 4 commits into from
Apr 14, 2021
Merged

Fixed function create npe #109

merged 4 commits into from
Apr 14, 2021

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented Apr 13, 2021

  • Fixed function create npe

@tuteng tuteng requested review from freeznet and nlu90 as code owners April 13, 2021 00:55
freeznet
freeznet approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@freeznet freeznet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but left one comment about clean up the debug print, PTAL, thanks.

java-proxy/src/main/java/io/streamnative/function/mesh/proxy/util/FunctionsUtil.java Outdated
ConsumerConfig consumerConfig = functionConfig.getInputSpecs().get(sourceKey);
if (consumerConfig == null || StringUtils.isBlank(consumerConfig.getSerdeClassName())) {
throw new RestException(Response.Status.BAD_REQUEST, "inputSpecs.source.serdeClassName is not provided");
System.out.println("funciton config");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should delete the debug print here.

@tuteng tuteng merged commit 66ef644 into master Apr 14, 2021
@tuteng tuteng deleted the fix/function-create-issue branch April 14, 2021 04:02
freeznet pushed a commit that referenced this pull request Apr 14, 2021
@tuteng @freeznet
Fixed function create npe (#109)
ec0f330 
* Fixed function create npe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeznet freeznet freeznet approved these changes

@nlu90 nlu90 Awaiting requested review from nlu90 nlu90 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuteng @freeznet