Refactor scripts to build bundle and catalog #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeznet
approved these changes
Apr 15, 2021
nlu90
requested changes
Apr 19, 2021
PROJECT
Outdated
Comment on lines
7
to
8
| domain: streamnative.io | ||
| group: cloud |
Contributor
There was a problem hiding this comment.
with the recent group change, we migrated to
domain: functionmesh.io
group: compute
These fields here also need to be updated
freeznet
approved these changes
Apr 23, 2021
Member
freeznet
left a comment
freeznet
left a comment
There was a problem hiding this comment.
LGTM, but I have got a question why comment out compute.functionmesh.io_functionmeshes.yaml?
config/crd/kustomization.yaml
Outdated
| # It should be run by config/default | ||
| resources: | ||
| - bases/compute.functionmesh.io_functionmeshes.yaml | ||
| # - bases/compute.functionmesh.io_functionmeshes.yaml |
Member
There was a problem hiding this comment.
why we comment out compute.functionmesh.io_functionmeshes.yaml here?
Contributor
Author
Because it's too large and cannot be installed by OLM at the moment. Since the cloud integration doesn't require this CRD for now, the PR ignores it as a matter of expediency. |
nlu90
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefileto support building the operator catalogbundle/andbundle.Makefile