Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support mount secret file, fixed namespace #158

Merged
merged 10 commits into from
May 21, 2021
Merged

Support mount secret file, fixed namespace #158

merged 10 commits into from
May 21, 2021

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented May 17, 2021

  • Support mount secret file
  • Fixed k8s namespace
  • Upgrade pulsar broker version
  • Update pulsar groupId

@tuteng
Fixed namespace
2467e21 
Support mount secret file
@tuteng tuteng requested review from freeznet and nlu90 as code owners May 17, 2021 10:22
@tuteng tuteng self-assigned this May 17, 2021
@tuteng tuteng requested a review from fantapsody May 17, 2021 13:40
@tuteng tuteng mentioned this pull request May 18, 2021
Closed
5 tasks
nlu90
nlu90 reviewed May 18, 2021
View reviewed changes
mesh-worker-service/src/main/resources/functions_worker.yml Outdated
defaultMode: 420
secretName: pulsarcluster-data
authConfigMap: function-mesh-configmap-auth-public-default-testd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

encode the instance-name & cluster-name is good enough

@tuteng
Copy link
Member Author

tuteng commented May 20, 2021 •
edited
Loading

Update:

Add custom label for encode clusterName, tenant, namespace, name


'pulsar-cluster': 
'pulsar-tenant': 
'pulsar-namespace':
'pulsar-component':

sha => 
`sink-auth-` + hash
`source-auth-` + hash
`function-auth-` + hash

@tuteng tuteng merged commit 7c483d1 into master May 21, 2021
@tuteng tuteng deleted the fix/support-load-custome-auth-config-and-secret branch May 21, 2021 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlu90 nlu90 nlu90 approved these changes

@fantapsody fantapsody fantapsody approved these changes

@freeznet freeznet Awaiting requested review from freeznet freeznet is a code owner

Assignees

@tuteng tuteng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuteng @fantapsody @nlu90