Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sink/source component observation logic. #217

Merged
merged 4 commits into from
Jun 28, 2021
Merged

Update sink/source component observation logic. #217

merged 4 commits into from
Jun 28, 2021

Conversation

MarvinCai
Copy link
Contributor

@MarvinCai MarvinCai commented Jun 23, 2021 •
edited
Loading

fix: #215
Update sink/source component observation so it can properly observe & update status when sub-source is gone and allow recreation of the resource.

@MarvinCai
Update sink/source component observation logic.
9163550 
Update sink/source component observation so it can properly update status when sub-source is gone and allow recreation of the resource.
@MarvinCai MarvinCai requested review from fantapsody, nlu90 and a team June 23, 2021 05:04
@MarvinCai MarvinCai requested a review from freeznet as a code owner June 23, 2021 05:04
nlu90
nlu90 requested changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@nlu90 nlu90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the general idea that during the observe phase, we build status from the observed result. (i.e., take the cluster actual running status as the source of truth).

But some part of the PR needs to be refined and discussed.

controllers/sink.go Outdated Show resolved Hide resolved
controllers/sink.go Outdated Show resolved Hide resolved
controllers/sink.go Outdated Show resolved Hide resolved
@MarvinCai MarvinCai requested a review from nlu90 June 25, 2021 01:51
MarvinCai added 2 commits June 25, 2021 10:55
@MarvinCai
Address comments.
18b7e1e 
Make default action Noaction and change according to observed status.
@MarvinCai
Fix checkstyle violation.
32e48a4
nlu90
nlu90 reviewed Jun 25, 2021
View reviewed changes
controllers/sink.go Outdated Show resolved Hide resolved
controllers/sink.go Outdated Show resolved Hide resolved
@MarvinCai MarvinCai requested a review from nlu90 June 28, 2021 07:03
@MarvinCai
Copy link
Contributor Author

@nlu90 PTAL

@nlu90 nlu90 merged commit bd4c53f into master Jun 28, 2021
@nlu90 nlu90 deleted the zxc/fix-observe branch June 28, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlu90 nlu90 nlu90 approved these changes

@freeznet freeznet freeznet approved these changes

@fantapsody fantapsody Awaiting requested review from fantapsody

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Controller] Connector StatefulSet is not recreated after deletion.
3 participants
@MarvinCai @freeznet @nlu90