enable source connector to set ForwardMessageProperty #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeznet
approved these changes
Aug 10, 2021
controllers/spec/utils.go
Outdated
| ProducerSpec: &producerSpec, | ||
| SerDeClassName: source.Spec.Output.SinkSerdeClassName, | ||
| SchemaType: source.Spec.Output.SinkSchemaType, | ||
| ForwardSourceMessageProperty: *source.Spec.ForwardSourceMessageProperty, |
There was a problem hiding this comment.
The webhook is not available in tests, so ForwardSourceMessageProperty might be nil if not provided.
There was a problem hiding this comment.
I thought I add a webhook for the check. Let me know if this helps
There was a problem hiding this comment.
yes, but the webhook is disabled by default, and needs some extra configs to make it work. I was working on that with #238, before the webhook is working, we can consider adding kubebuilder CRD validation markers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #249