Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply istio service port name convention to function-mesh services #343

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

freeznet
Copy link
Member

Fixes #326

Motivation

apply function-mesh services with Istio service port naming convention

ref: https://istio.io/latest/docs/reference/config/analysis/ist0118/

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet requested a review from nlu90 as a code owner March 22, 2022 01:34
@freeznet freeznet self-assigned this Mar 22, 2022
@freeznet freeznet requested a review from fantapsody March 22, 2022 01:34
@github-actions
Copy link

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Mar 22, 2022
@freeznet freeznet added type/enhancement Indicates an improvement to an existing feature component/controller labels Mar 22, 2022
@freeznet freeznet merged commit 96828a9 into master Mar 22, 2022
@freeznet freeznet deleted the freeznet/apply-istio-service-port-name-convention branch March 22, 2022 22:56
@freeznet freeznet added this to the v0.1.11 milestone Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/controller doc-info-missing This pr needs to mark a document option in description type/enhancement Indicates an improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verify the compatibility with Istio
3 participants