Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kustomize before crd in release command in Makefile #395

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Add kustomize before crd in release command in Makefile #395

merged 1 commit into from
Jun 17, 2022

Conversation

tpiperatgod
Copy link
Contributor

Signed-off-by: laminar tpiperatgod@gmail.com

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

To fix the issue as follows in the release action:

/bin/sh: 1: /home/runner/work/function-mesh/function-mesh/bin/kustomize: not found

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

for fix issue as follows:

```
/bin/sh: 1: /home/runner/work/function-mesh/function-mesh/bin/kustomize: not found
```

Signed-off-by: laminar <tpiperatgod@gmail.com>
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jun 17, 2022
@freeznet freeznet merged commit 328dba3 into streamnative:master Jun 17, 2022
tpiperatgod added a commit that referenced this pull request Jun 17, 2022
for fix issue as follows:

```
/bin/sh: 1: /home/runner/work/function-mesh/function-mesh/bin/kustomize: not found
```

Signed-off-by: laminar <tpiperatgod@gmail.com>
@tpiperatgod tpiperatgod deleted the fix_release_issue branch June 17, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m/2022-07 no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants