-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use init container to download packages and functions #411
Conversation
there are two ways to achieve this:
I prefer the 2nd way, do you have any opinions? |
82a5feb
to
e2d33c7
Compare
31a84af
to
24fc7f7
Compare
9b07407
to
c4404d6
Compare
for the compatibility issue, I tested that we can pass undefined fields when creating k8s resources, like with FM v0.4.0, which doesn't define the pulsar:
pulsarConfig: "test-pulsar"
authSecret: "test-auth"
tlsSecret: "test-tls"
oauth2Config:
audience: "test"
clientId: "test"
issuerUrl: "aaa.com"
keySecretName: "test-secret"
keySecretKey: "credential.json" the controller works well and just ignores the undefined so for compatibility, we can support passing the related issue: https://github.com/streamnative/function-mesh-worker-service/issues/334 |
de10ec5
to
bd764e8
Compare
@streamnative/serverless |
The doc is updated for this feature through this doc PR. Therefore, remove the doc-required label and add the doc-added label. |
Fixes #400
Wait for function-mesh-worker-service support oauth2, leave any comment you want
Motivation
Use an init container to download packages/functions from pulsar: #390 (comment)
Modifications
Attach an init container and empty volume if JarLocation/PyLocation/GoLocation is specified
Verifying this change
Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
Documentation
doc-required
need docs for dev