Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CSV for openshift #417

Merged
merged 23 commits into from
Aug 10, 2022
Merged

Conversation

freeznet
Copy link
Member

@freeznet freeznet commented Jul 4, 2022

Fixes #385

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet requested review from nlu90 and a team as code owners July 4, 2022 09:46
@github-actions
Copy link

github-actions bot commented Jul 4, 2022

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Jul 4, 2022
@freeznet freeznet force-pushed the freeznet/complete-ClusterServiceVersion branch from a997e23 to c45ed53 Compare July 5, 2022 07:41
nlu90
nlu90 previously approved these changes Aug 1, 2022
Copy link
Contributor

@nlu90 nlu90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the conflicts?

@freeznet freeznet added area/ci type/enhancement Indicates an improvement to an existing feature m/2022-08 component/controller labels Aug 3, 2022
@github-actions github-actions bot removed the doc-info-missing This pr needs to mark a document option in description label Aug 3, 2022
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

@freeznet:Thanks for providing doc info!

@github-actions github-actions bot added the no-need-doc This pr does not need any document label Aug 3, 2022
@freeznet freeznet force-pushed the freeznet/complete-ClusterServiceVersion branch from e4bb54d to dcceaa7 Compare August 8, 2022 09:14
jiangpengcheng
jiangpengcheng previously approved these changes Aug 9, 2022
@freeznet freeznet modified the milestone: 2022-08 v0.5.0 Aug 10, 2022
@freeznet freeznet merged commit 3e267bb into master Aug 10, 2022
@freeznet freeznet deleted the freeznet/complete-ClusterServiceVersion branch August 10, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci component/controller m/2022-08 no-need-doc This pr does not need any document type/enhancement Indicates an improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certify function-mesh operator with Red Hat OpenShift Operator Certification
3 participants