Some small types fixed in readme and makefile #423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I was following the README and found two small issues preventing me from running the code.
Modifications
One was a typo (I think) for the operator-sdk. The README has
--controller-true
. I think this is a mistake since I see the operation is--controller=true
in the operator-sdk docs and cli on my computer.The second issue I had was when running
make run
. Main.go would crash setting up the webhook. Readingfunction-mesh/main.go
Lines 151 to 153 in 4ed298a
make run
. I've set it to thus. (An alternative 'fix' would be the README saying to runENABLE_WEBHOOKS=false make run
as opposed tomake run
.)These may both be non-issues. Feel free to correct any misunderstanding I have.
Thanks!
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required
(Your PR needs to update docs and you will update later)
[ x ]
doc-not-needed
It is cleaning up docs
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)