Allow key-value Environment variable passthrough. #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangpengcheng
approved these changes
Jul 11, 2022
freeznet
approved these changes
Jul 11, 2022
freeznet
reviewed
Jul 11, 2022
There was a problem hiding this comment.
@jdmaguire thanks for the PR, please check my comments, thanks.
added 3 commits
July 11, 2022 08:46
github-actions
bot
added
doc
jdmaguire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
.spec.secretsMapexists to pass some configuration to the sinks/sources/functions. Using this for plain, simple configuration is ambiguous/unintuitive and is more complicated since it requires multiple K8s resources (i.e. the Function CR and a k8s Secret).I'm not deeply familiar with this project. Feel free to suggest alternatives or dismiss it as you see fit.
Modifications
Introduces
.spec.envthat gets combined with.spec.secretsMapto form the environment variables for the statefulset/pods deployed by this.Verifying this change
I verified this change by manually creating the CRs,
kubectl exec'ing in and verifying that things work w/o.spec.envas before and with.spec.env. I should add more tests but I wasn't familiar with this codebase so I wanted to write the code and get the PR up first.Documentation
Check the box below.
Need to update docs?
[]
doc-requiredno-need-docdoc