Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ctrl.CreateOrUpdate to apply resource #427

Merged
merged 1 commit into from
Jul 14, 2022
Merged

use ctrl.CreateOrUpdate to apply resource #427

merged 1 commit into from
Jul 14, 2022

Conversation

tpiperatgod
Copy link
Contributor

Signed-off-by: laminar tpiperatgod@gmail.com

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #421

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Instead of using .status.conditions.action to determine whether a resource should be updated or created, use the ctrl.CreateOrUpdate function to apply the resource

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

Instead of using `.status.conditions.action` to determine whether a resource should be updated or created, use the ctrl.CreateOrUpdate function to apply the resource

Signed-off-by: laminar <tpiperatgod@gmail.com>
@tpiperatgod tpiperatgod requested review from nlu90, freeznet and a team as code owners July 12, 2022 15:10
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jul 12, 2022
@freeznet freeznet merged commit fe2d591 into streamnative:master Jul 14, 2022
@tpiperatgod tpiperatgod deleted the issue-421 branch July 14, 2022 03:44
@nlu90
Copy link
Contributor

nlu90 commented Jul 18, 2022

👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m/2022-07 no-need-doc This pr does not need any document type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FunctionMesh Operator stateful set image update problem
4 participants