Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt openshift olm annotation #488

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

freeznet
Copy link
Member

@freeznet freeznet commented Oct 21, 2022

Master Issue: #486

Motivation

Fix failure in redhat-openshift-ecosystem/certified-operators#1421

https://docs.openshift.com/container-platform/4.8/operators/operator_sdk/osdk-working-bundle-images.html#osdk-control-compat_osdk-working-bundle-images%22
add olm.properties to OLM annotation when build the openshift bundles

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet self-assigned this Oct 21, 2022
@freeznet freeznet requested review from nlu90 and a team as code owners October 21, 2022 09:13
@github-actions
Copy link

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added doc-info-missing This pr needs to mark a document option in description and removed doc-info-missing This pr needs to mark a document option in description labels Oct 21, 2022
@github-actions
Copy link

@freeznet:Thanks for providing doc info!

@github-actions github-actions bot added the no-need-doc This pr does not need any document label Oct 21, 2022
@freeznet freeznet merged commit 810c85d into master Oct 28, 2022
@freeznet freeznet deleted the freeznet/adopt-openshift-olm-properties branch October 28, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m/2022-11 no-need-doc This pr does not need any document ready-to-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants