fix python runner oauth2 #506
Conversation
|
@freeznet:Thanks for your contribution. For this PR, do we need to update docs? |
2 similar comments
|
@freeznet:Thanks for your contribution. For this PR, do we need to update docs? |
|
@freeznet:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
github-actions
bot
removed
the
doc-info-missing
|
@freeznet:Thanks for providing doc info! |
.ci/tests/integration-oauth2/cases/py-download-function-legacy/verify.sh
Show resolved
Hide resolved
| pod: | ||
| volumes: | ||
| - name: secret-broker-0 | ||
| secret: | ||
| defaultMode: 420 | ||
| secretName: sn-platform-oauth2-private-key | ||
| clusterName: test | ||
| autoAck: true | ||
| volumeMounts: | ||
| - mountPath: /mnt/secrets | ||
| name: sn-platform-oauth2-private-key | ||
| readOnly: true |
There was a problem hiding this comment.
I think volumes[0].name and volumeMounts[0].name should be the same
|
disable the legacy test case and tracking with #508 |
Fixes #489
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Make changes according to #489 (comment)
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)