Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable stateful configs to connectors #510

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

freeznet
Copy link
Member

@freeznet freeznet commented Nov 4, 2022

Fixes #509

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet added type/enhancement Indicates an improvement to an existing feature m/2022-11 labels Nov 4, 2022
@freeznet freeznet self-assigned this Nov 4, 2022
@freeznet freeznet requested review from nlu90 and a team as code owners November 4, 2022 08:53
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added doc-info-missing This pr needs to mark a document option in description labels Nov 4, 2022
@github-actions github-actions bot removed the doc-info-missing This pr needs to mark a document option in description label Nov 4, 2022
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

@freeznet:Thanks for providing doc info!

@github-actions github-actions bot added the doc-required This pr needs a document label Nov 4, 2022
@Huanli-Meng
Copy link
Contributor

The doc is updated for this code PR. Therefore, remove the doc-required label and add doc-added label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-added m/2022-11 ready-to-review type/enhancement Indicates an improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable stateful configs to connectors
4 participants