Add a flag to enable/disable downloader #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangpengcheng
requested review from
nlu90,
freeznet and
a team
as code owners
11 tasks
freeznet
previously approved these changes
Nov 9, 2022
utils/configs.go
Outdated
| // Package utils define some common used functions&structs | ||
| package utils | ||
|
|
||
| var EnableDownloader = false |
There was a problem hiding this comment.
Can we make this config to EnableInitContainers so we could use the feature flag in future if we want to involve more init containers?
nlu90
previously approved these changes
Nov 9, 2022
freeznet
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #502
Motivation
init container may not able to access the pulsar cluster when istio is used and strict mode is enabled
Modifications
add a flag to enable/disable downloader container, default to false
Verifying this change
Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)