Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a connector sample #541

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

freeznet
Copy link
Member

@freeznet freeznet commented Dec 2, 2022

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

  • add connector image sample
  • fix runner base build error
  • specific platform when build

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet requested a review from nlu90 as a code owner December 2, 2022 07:03
@freeznet freeznet self-assigned this Dec 2, 2022
@freeznet freeznet requested a review from a team as a code owner December 2, 2022 07:03
@freeznet freeznet added type/enhancement Indicates an improvement to an existing feature component/runner-images m/2022-12 labels Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added doc-info-missing This pr needs to mark a document option in description and removed doc-info-missing This pr needs to mark a document option in description labels Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

@freeznet:Thanks for providing doc info!

@github-actions github-actions bot added the no-need-doc This pr does not need any document label Dec 2, 2022
Copy link
Contributor

@imaffe imaffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, did these docker images got pushed to remote container registry (seem the es sample connector is not pushed to kind as well)? How will these containers be used ?

images/samples/build.sh Outdated Show resolved Hide resolved
@freeznet
Copy link
Member Author

freeznet commented Dec 5, 2022

Just curious, did these docker images got pushed to remote container registry (seem the es sample connector is not pushed to kind as well)? How will these containers be used ?

this is just act as a sample Dockerfile to show user how to build a connector image.

@imaffe imaffe merged commit 698546e into streamnative:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/runner-images m/2022-12 no-need-doc This pr does not need any document ready-to-review type/enhancement Indicates an improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants