504: change samples function to make documenation steps work #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imaffe:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
imaffe
changed the title
|
For traceability this is for #504. |
imaffe
changed the title
jiangpengcheng
approved these changes
Dec 6, 2022
freeznet
approved these changes
Dec 6, 2022
xiaogang-sn
added a commit
that referenced
this pull request
Dec 6, 2022
When using the existing example of compute_v1alpha1_functionmesh.yaml, it complains about the format of jarLocation and uploading jar package requires additional steps. Inspired by #542 the Docker image is used here for the Function which eliminates the steps to handle package uploading to make the onboarding easier.
4 tasks
This was referenced Dec 6, 2022
Merged
Huanli-Meng
added
doc-added
and removed
doc-info-missing
freeznet
added a commit
that referenced
this pull request
Dec 9, 2022
* Update the FunctionMesh config example to use Docker images When using the existing example of compute_v1alpha1_functionmesh.yaml, it complains about the format of jarLocation and uploading jar package requires additional steps. Inspired by #542 the Docker image is used here for the Function which eliminates the steps to handle package uploading to make the onboarding easier. * Fix the inconsistency in the comment Co-authored-by: Rui Fu <freeznet@users.noreply.github.com> * Fix another inconsistency in the comments Co-authored-by: Rui Fu <freeznet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use the sample runner image, or the
pulsar-allimageFixes #504
fix #504