Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclusivity to the BuiltinHPARule #549

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Add exclusivity to the BuiltinHPARule #549

merged 1 commit into from
Dec 27, 2022

Conversation

tpiperatgod
Copy link
Contributor

Signed-off-by: laminar tpiperatgod@gmail.com

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #547

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

  • add validateBuiltinHPARules() to prevent users from submitting HPA rules for duplicate metrics.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@tpiperatgod tpiperatgod requested review from nlu90, freeznet and a team as code owners December 19, 2022 11:21
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Dec 19, 2022
Signed-off-by: laminar <tpiperatgod@gmail.com>
@freeznet freeznet added m/2023-01 component/controller type/enhancement Indicates an improvement to an existing feature labels Dec 27, 2022
@freeznet freeznet merged commit 64746e1 into streamnative:master Dec 27, 2022
@tpiperatgod tpiperatgod deleted the issue-547 branch December 27, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/controller m/2023-01 no-need-doc This pr does not need any document type/enhancement Indicates an improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The BuiltinHPARule should have exclusivity
2 participants