-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration tools for function #80
Conversation
…m:streamnative/function-mesh into feature/add-a-tool-for-migration-function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leave my comments
parallelism should be mapping to replicas, not MaxReplicas
The SourceType and SinkType are shortcut for built-in connectors based on the doc here. Currently we don't have built-in connectors, so the migration tool might want to reference how pulsar handles such built-in connectors translating |
I think there are some misusage of According to pulsar's doc, when running builtin IO connectors, user can just use But for function-mesh, it acts differently. Like in function-mesh/api/v1alpha1/sink_types.go Lines 36 to 37 in d7deb90
function-mesh/controllers/spec/utils.go Line 242 in d7deb90
function-mesh/controllers/spec/utils.go Line 266 in d7deb90
I have created |
f5f0cf0
to
2855e60
Compare
I don't think we can get the values of So there are two possible ways to solve this problem
|
Fixed #77
Mapped field