Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

[FEATURE] Add commit offset test for Kafka clients of different versions #681

Closed
BewareMyPower opened this issue Aug 27, 2021 · 2 comments · Fixed by #686
Closed

[FEATURE] Add commit offset test for Kafka clients of different versions #681

BewareMyPower opened this issue Aug 27, 2021 · 2 comments · Fixed by #686
Assignees
@wenbingshen
Labels
type/feature Indicates new functionality

Comments

@BewareMyPower
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
#605 added a test framework for Kafka clients of different versions. However, it only added the basic e2e test, an important API commitOffset was not verified.

Describe the solution you'd like
Add commit offset test in BasicEndToEndPulsarTest and BasicEndToEndKafkaTest in io.streamnative.pulsar.handlers.kop.compatibility package.
@BewareMyPower BewareMyPower added the type/feature Indicates new functionality label Aug 27, 2021
@BewareMyPower
Copy link
Collaborator Author

@wenbingshen Since you're working on the compatibility with older Kafka client, I think we should add tests to cover commitOffset API.

@wenbingshen
Copy link
Contributor

@wenbingshen Since you're working on the compatibility with older Kafka client, I think we should add tests to cover commitOffset API.

Good issue. You can assign this question to me first. I am willing to try to work for this. :)

This was referenced Aug 27, 2021
Merged
Closed
BewareMyPower pushed a commit that referenced this issue Sep 1, 2021
@wenbingshen
[FEATURE] Add commit offset test for Kafka clients of different versi…
13004f7 
…ons (#686)

Fixes #681 #687

### Motivation
#605 added a test framework for Kafka clients of different versions. However, it only added the basic e2e test, an important API commitOffset was not verified.

### Modifications
Add commit offset test in BasicEndToEndPulsarTest and BasicEndToEndKafkaTest in io.streamnative.pulsar.handlers.kop.compatibility package.

This feature belongs to the compatibility issue between different versions of kafka client and kop.
BewareMyPower pushed a commit that referenced this issue Sep 1, 2021
@wenbingshen @BewareMyPower
[FEATURE] Add commit offset test for Kafka clients of different versi…
429cac0 
…ons (#686)

Fixes #681 #687

### Motivation
#605 added a test framework for Kafka clients of different versions. However, it only added the basic e2e test, an important API commitOffset was not verified.

### Modifications
Add commit offset test in BasicEndToEndPulsarTest and BasicEndToEndKafkaTest in io.streamnative.pulsar.handlers.kop.compatibility package.

This feature belongs to the compatibility issue between different versions of kafka client and kop.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wenbingshen wenbingshen

Labels
type/feature Indicates new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEATURE] Add commit offset test for Kafka clients of different versions wenbingshen/kop
2 participants
@BewareMyPower @wenbingshen