This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Add Time based metric exipration. #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifepuzzlefun
requested review from
BewareMyPower and
Demogorgon314
as code owners
|
|
|
@lifepuzzlefun:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
doc-info-missing
|
@lifepuzzlefun:Thanks for providing doc info! |
Codecov Report
@@ Coverage Diff @@
## master #1996 +/- ##
============================================
- Coverage 17.05% 17.04% -0.02%
Complexity 728 728
============================================
Files 191 191
Lines 14235 14248 +13
Branches 1332 1336 +4
============================================
Hits 2428 2428
- Misses 11631 11644 +13
Partials 176 176
|
BewareMyPower
approved these changes
Aug 14, 2023
Demogorgon314
pushed a commit
to Demogorgon314/kop
that referenced
this pull request
Oct 30, 2023
Fixes streamnative#1956 ### Motivation FastThreadLocal wont cleanup until thread exit. so we can just check if the stats is not recorded a long time if expired just remove from threadlocal ### Modifications add time check logic if long time have no record just remove the stats. (cherry picked from commit 33d3c04)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1956
Motivation
FastThreadLocal wont cleanup until thread exit. so we can just check if the stats is not recorded a long time if expired just remove from threadlocal
Modifications
add time check logic if long time have no record just remove the stats.
Verifying this change
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)