This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Fix topic creation may not complete after METADATA response is sent #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhai
approved these changes
May 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
Sometimes
DifferentNamespaceTestmay fail, after checking the logs I found send failed.Kafka 2.0 client's default
retryconfig is 0, so it won't attempt to send message again.It's because when KoP handled PRODUCE request, the
PersistentTopicinstance of broker was not created. It's because when a topic was automatically created, an asynchronous method was called but METADATA response future didn't wait for it. The followed lookup request doesn't need a topic to be created.Modifications
When a METADATA request is handled and a topic is created automatically, wait until the topic creation is completed.