This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Fix deadlock caused by KafkaTopicConsumerManager #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhai
approved these changes
Jul 23, 2021
BewareMyPower
added a commit
to BewareMyPower/kop
that referenced
this pull request
Jul 25, 2021
Fixes streamnative#618 ### Motivation See streamnative#618 (comment) for the deadlock analysis. ### Modifications - Use `ConcurrentHashMap` instead of `ConcurrentLongHashMap`. Though this bug may already be fixed in apache/pulsar#9787, the `ConcurrentHashMap` from Java standard library is more reliable. The possible performance enhancement brought by `ConcurrentLongHashMap` still needs to be proved. - Use `AtomicBoolean` as `KafkaTopicConsumerManager`'s state instead of read-write lock to avoid `close()` method that tries to acquire write lock blocking. - Run a single cursor expire task instead one task per channel, since streamnative#404 changed `consumerTopicManagers` to a static field, there's no reason to run a task for each connection.
BewareMyPower
added a commit
that referenced
this pull request
Jul 25, 2021
Fixes #618 ### Motivation See #618 (comment) for the deadlock analysis. ### Modifications - Use `ConcurrentHashMap` instead of `ConcurrentLongHashMap`. Though this bug may already be fixed in apache/pulsar#9787, the `ConcurrentHashMap` from Java standard library is more reliable. The possible performance enhancement brought by `ConcurrentLongHashMap` still needs to be proved. - Use `AtomicBoolean` as `KafkaTopicConsumerManager`'s state instead of read-write lock to avoid `close()` method that tries to acquire write lock blocking. - Run a single cursor expire task instead one task per channel, since #404 changed `consumerTopicManagers` to a static field, there's no reason to run a task for each connection.
BewareMyPower
added a commit
to BewareMyPower/kop
that referenced
this pull request
Jul 25, 2021
BewareMyPower
added a commit
that referenced
this pull request
Jul 25, 2021
This PR migrates #620 to branch-2.7.2 because it's hard to cherry-pick.
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #618
Motivation
See #618 (comment) for the deadlock analysis.
Modifications
ConcurrentHashMapinstead ofConcurrentLongHashMap. Though this bug may already be fixed in Ensure read-lock is not continuously held on a section while iterating over concurrent maps apache/pulsar#9787, theConcurrentHashMapfrom Java standard library is more reliable. The possible performance enhancement brought byConcurrentLongHashMapstill needs to be proved.AtomicBooleanasKafkaTopicConsumerManager's state instead of read-write lock to avoidclose()method that tries to acquire write lock blocking.consumerTopicManagersto a static field, there's no reason to run a task for each connection.