This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[FEATURE] Add Authorizer used for authorization. #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Please also make Codacy analysis pass. |
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/security/Session.java
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/security/KafkaPrincipal.java
Outdated
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/security/auth/Resource.java
Show resolved
Hide resolved
BewareMyPower
suggested changes
Aug 16, 2021
...mpl/src/main/java/io/streamnative/pulsar/handlers/kop/security/auth/SimpleAclAuthorizer.java
Outdated
Show resolved
Hide resolved
BewareMyPower
suggested changes
Aug 16, 2021
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java
Outdated
Show resolved
Hide resolved
BewareMyPower
suggested changes
Aug 16, 2021
...mpl/src/main/java/io/streamnative/pulsar/handlers/kop/security/auth/SimpleAclAuthorizer.java
Outdated
Show resolved
Hide resolved
|
I've left some comments, PTAL. |
Thx, I've fixed, PTAL. |
Demogorgon314
force-pushed
the
add_authorizer
branch
from
a6eecc1
to
239e597
Compare
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/security/KafkaPrincipal.java
Outdated
Show resolved
Hide resolved
BewareMyPower
suggested changes
Aug 17, 2021
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/security/auth/ResourceType.java
Outdated
Show resolved
Hide resolved
|
Overall LGTM, left a comment, PTAL. |
BewareMyPower
approved these changes
Aug 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#236 Add Authorizer used for authorization.