This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Remove closed KafkaTopicConsumerManager from cache #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhai
approved these changes
Aug 17, 2021
BewareMyPower
added a commit
that referenced
this pull request
Aug 19, 2021
### Motivation When `KafkaTopicConsumerManager#removeCursorFuture()` returns null, it means the TCM (`KafkaTopicConsumerManager` instance) is closed accidentally. However, in this case, the TCM was not removed from `KafkaTopicConsumer.consumerTopicManagers` currently. Then next time `topicManager.getTopicConsumerManager` could still return the closed TCM. ### Modifications When `KafkaTopicConsumerManager#removeCursorFuture()` returns null, remove the TCM from cache.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When
KafkaTopicConsumerManager#removeCursorFuture()returns null, it means the TCM (KafkaTopicConsumerManagerinstance) is closed accidentally. However, in this case, the TCM was not removed fromKafkaTopicConsumer.consumerTopicManagerscurrently. Then next timetopicManager.getTopicConsumerManagercould still return the closed TCM.Modifications
When
KafkaTopicConsumerManager#removeCursorFuture()returns null, remove the TCM from cache.