Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

skip to get kafka advertised addres from zk when lookup with listenerName #670

Merged
merged 4 commits into from
Aug 26, 2021

Conversation

wangjialing218
Copy link
Contributor

This is the first step for #669, only support one listener which configed in kafkaListenerName, and only support PLAINTEXT

@BewareMyPower
Copy link
Collaborator

Could you fix the test?

@wangjialing218
Copy link
Contributor Author

This PR could resolve #633 if only PLAINTEXT is used.

@BewareMyPower
Copy link
Collaborator

It looks like KafkaListenerNameTest.testListenerName still failed, could you take a look?

@wangjialing218
Copy link
Contributor Author

It looks like KafkaListenerNameTest.testListenerName still failed, could you take a look?

Lookup has no problem, but kafka client can't connect to localAddress through kafkaBrokerPort, I changed localAddress to "localhost" and the test will be ok.
Maybe we do not need to use localAddress in this test.

@BewareMyPower
Copy link
Collaborator

Let's see what will happen in CI. I used to use localhost but it failed in CI so I changed it to ServiceConfigurationUtils.getDefaultOrConfiguredAddress(null) and it works.

@BewareMyPower BewareMyPower merged commit 5f2f79f into streamnative:master Aug 26, 2021
BewareMyPower pushed a commit that referenced this pull request Aug 26, 2021
…Name (#670)

This is the first step for #669, only support one listener which configed in `kafkaListenerName`, and only support PLAINTEXT

Co-authored-by: wangjialing <wangjialing@cmss.chinamobile.com>
@BewareMyPower BewareMyPower mentioned this pull request Aug 27, 2021
9 tasks
@BewareMyPower BewareMyPower added the type/feature Indicates new functionality label Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/feature Indicates new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants