This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[FEATURE] Add authorization to produce and consume #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demogorgon314
changed the title
Demogorgon314
changed the title
Demogorgon314
force-pushed
the
add-authorization-to-produce-and-consume
branch
from
6619e87
to
8448201
Compare
Demogorgon314
changed the title
3 tasks
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/MessageFetchContext.java
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java
Outdated
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java
Outdated
Show resolved
Hide resolved
|
I've done the review for code under |
BewareMyPower
suggested changes
Aug 26, 2021
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/PendingTopicFutures.java
Outdated
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/MessageFetchContext.java
Outdated
Show resolved
Hide resolved
BewareMyPower
suggested changes
Aug 26, 2021
...mpl/src/main/java/io/streamnative/pulsar/handlers/kop/security/auth/SimpleAclAuthorizer.java
Show resolved
Hide resolved
BewareMyPower
suggested changes
Aug 26, 2021
tests/src/test/java/io/streamnative/pulsar/handlers/kop/KafkaAuthorizationTestBase.java
Outdated
Show resolved
Hide resolved
BewareMyPower
approved these changes
Aug 26, 2021
BewareMyPower
pushed a commit
that referenced
this pull request
Aug 26, 2021
## Motivation #236 Add authorization to produce and consumer ## Modifications * Add authorization to `handleProduceRequest` * Add authorization to `handleOffsetFetchRequest` * Add authorization to `handleListOffsetRequest` * Add authorization to `MessageFetchContext#handleFetch` * Add new test units for produce or consume permissions * Add new test units for topic level permissions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#236 Add authorization to produce and consumer
Modifications
handleProduceRequesthandleOffsetFetchRequesthandleListOffsetRequestMessageFetchContext#handleFetch