This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[BUGFIX] handle unsupported ApiVersionsRequest when channelPrepare #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BewareMyPower PTAL, Thanks. :) |
BewareMyPower
approved these changes
Aug 31, 2021
|
I merged this PR first. I think we can add test for highest version Kafka client at the moment later. |
You are right, I can add a test for this. |
BewareMyPower
pushed a commit
that referenced
this pull request
Sep 1, 2021
fixes #688 ### Motivation if enable sasl/plain, the apiVersionRequest request will fail when the client use higher than the Kafka-2.0 version protocol. ### Modifications Do special processing for unsupported ApiVersionsRequest like KafkaCommandDecoder's byteBufToRequest, and return UNSUPPORTED_VERSION error to the client.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #688
Motivation
if enable sasl/plain, the apiVersionRequest request will fail when the client use higher than the Kafka-2.0 version protocol.
Modifications
Do special processing for unsupported ApiVersionsRequest like KafkaCommandDecoder's byteBufToRequest, and return UNSUPPORTED_VERSION error to the client.