Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(327): assert the lastPushed as -1 or 0 #421

Merged
merged 1 commit into from
Dec 29, 2023
Merged

fix(327): assert the lastPushed as -1 or 0 #421

merged 1 commit into from
Dec 29, 2023

Conversation

lsytj0413
Copy link
Contributor

Fixed: #327

The assert.Equal may run before streamEntries or after streamEntries, so the LastPushed maybe -1 or 0.

@lsytj0413
fix(327): assert the lastPushed as -1 or 0
ae2b20e 
Signed-off-by: Soren Yang <lsytj0413@gmail.com>
@lsytj0413 lsytj0413 mentioned this pull request Dec 29, 2023
Merged
@merlimat merlimat merged commit 5df5466 into streamnative:main Dec 29, 2023
4 checks passed
@lsytj0413 lsytj0413 deleted the fix-327 branch December 30, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@mattisonchao mattisonchao Awaiting requested review from mattisonchao mattisonchao is a code owner

@coderzc coderzc Awaiting requested review from coderzc coderzc is a code owner

@RobertIndie RobertIndie Awaiting requested review from RobertIndie RobertIndie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test: TestFollowerCursor
2 participants
@lsytj0413 @merlimat