Secondary indexes implementation #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
requested review from
mattisonchao,
coderzc and
RobertIndie
as code owners
merlimat
pushed a commit
that referenced
this pull request
Oct 10, 2024
### Motivation
In the old logic, there's the wrong usage for iteration is as follow:
```golang
for it.Next() {
err := updateOperationCallback.OnDelete(batch, it.Key())
if err != nil {
return errors.Wrap(multierr.Combine(err, it.Close()), "oxia db: failed to delete range")
}
}
```
After pr #544, we already added a `deleteRange` callback. Therefore, we
can delete this wrong logic directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server side implementation for secondary indexes.