Fixes around service discovery, engine and consumer. #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
|
The dashboard that I use to check if the fix works :D We are able to treat batch messages!
|
FlorentinDUBOIS
force-pushed
the
master
branch
from
e33ffba to
a3e9b86
Compare
CleverAkanoa
requested changes
Dec 19, 2024
…d topic Co-authored-by: @Wonshtrum <eloi.demolis@clever-cloud.com> Co-authored-by: @KannarFr <alexandre.duval@clever-cloud.com> Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
…egex for topic discovery Co-authored-by: @Wonshtrum <eloi.demolis@clever-cloud.com> Co-authored-by: @KannarFr <alexandre.duval@clever-cloud.com> Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
…ssage Co-authored-by: @Wonshtrum <eloi.demolis@clever-cloud.com> Co-authored-by: @KannarFr <alexandre.duval@clever-cloud.com> Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
FlorentinDUBOIS
force-pushed
the
master
branch
from
a3e9b86 to
ef7c063
Compare
Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
|
Who should review this? (and merge) |
|
Akanoa and I could do both, but I was waiting for people who works with at streamnative to review as well. |
freeznet
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remaining_messagesvariable. The symptom was that consumer stop receiving messages, because they do not send any flow control message due to the invalid remaining message number. We also fix a bug that create a reconnect loop, because the driver consider that the newly created connection was already disconnected due to same origin.