Expose some monitor metrics #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amehochan:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
|
@amehochan Thanks for the contribution. |
amehochan
force-pushed
the
feature/expose-monitor-metrics
branch
from
8c478c1 to
c8bf93d
Compare
|
The code lint issues matters. I have passed the checkstyle on my local machine. And format the code by using same formatter like spark. |
amehochan
force-pushed
the
feature/expose-monitor-metrics
branch
from
c8bf93d to
f6e30ef
Compare
syhily
approved these changes
Feb 8, 2023
nlu90
added a commit
that referenced
this pull request
Apr 7, 2023
* Revert "Expose some monitor metrics (#106)" This reverts commit d7d955c. * Reader need closed when exception (#115) * fix: Reader did not closed when an exception occurred in readNext * fix: Reader did not closed when an exception occurred in readNext * [Improve] replace admin calls with client or consumer calls in PulsarHelper (#118) * introduce pulsar consumer for pulsar management * use consumer cache * lint error * remove admin url from source related components (#120) * simplify sink schema check (#121) --------- Co-authored-by: obobj <vinicolor.violet.end@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.