Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] remove admin parameter from sinks and admin options from config #122

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

nlu90
Copy link
Collaborator

@nlu90 nlu90 commented Apr 3, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #113

Motivation

Remove dependency on Pulsar Admin

Modifications

  1. remove admin related configs
  2. remove admin parameters from sink related components

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required
    All pulsar admin-related options are removed. Users no longer need to provide admin configurations

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • [] doc

    (If this PR contains doc changes)

@nlu90 nlu90 added this to the 2023-04 v3.2.0.2 milestone Apr 3, 2023
@nlu90 nlu90 requested review from freeznet and jiangpengcheng April 3, 2023 17:02
@nlu90 nlu90 self-assigned this Apr 3, 2023
@nlu90 nlu90 requested a review from a team as a code owner April 3, 2023 17:02
@github-actions github-actions bot added the doc-required This pr needs a document label Apr 3, 2023
@nlu90 nlu90 changed the title remove admin parameter from sinks and admin options from config [improve] remove admin parameter from sinks and admin options from config Apr 3, 2023
@nlu90 nlu90 changed the title [improve] remove admin parameter from sinks and admin options from config [Improve] remove admin parameter from sinks and admin options from config Apr 3, 2023
@nlu90 nlu90 merged commit 2033aca into master Apr 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the neng/clean-admin-config branch April 4, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required This pr needs a document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants