Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the null pointer exception when there is no active session in the current thread. #139

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

chaoqin-li1123
Copy link
Contributor

@chaoqin-li1123 chaoqin-li1123 commented Jul 23, 2023

Motivation

#37 reported that null pointer exception may be thrown from jsonOptions if there is no active spark session.

Modifications

Call SparkSession.builder().getOrCreate(). It will look up the thread local spark session, then global session, and create a new session if neither exists.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

  • This change is a trivial rework / code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:

  • This change added tests and can be verified as follows:

Documentation

Check the box below.

Need to update docs?

  • doc-required
  • no-need-doc
  • doc

@chaoqin-li1123 chaoqin-li1123 requested review from nlu90 and a team as code owners July 23, 2023 18:39
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jul 23, 2023
@nlu90 nlu90 merged commit 5933f2f into streamnative:master Jul 24, 2023
@nlu90 nlu90 mentioned this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants