Adding PulsarAdmin configs to PulsarHelper #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chaoqin-li1123 For some reason I can't add you as a reviewer |
src/main/scala/org/apache/spark/sql/pulsar/PulsarProvider.scala
Outdated
Show resolved
Hide resolved
|
Code change LGTM, Thanks for the work! |
|
Can we add a small test for this change? Set one of the pulsar.admin.* option in the query, if this option is invalid, an exception should be thrown. |
nlu90
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #151 we added
admin.urlwithout adding Admin Confs.Modifications
Describe the modifications you've done.
Basically reverting #120
Verifying this change
(Please pick either of the following options)
[ x] This change is a trivial rework / code cleanup without any test coverage.
This change is already covered by existing tests, such as:
This change added tests and can be verified as follows:
Documentation
Check the box below.
Need to update docs?
doc-requiredno-need-docdoc