Add support to 0 pos value #37
Conversation
| @@ -316,7 +316,7 @@ function generateBidParameters(bid, bidderRequest) { | |||
| }; | |||
|
|
|||
| const pos = deepAccess(bid, `mediaTypes.${mediaType}.pos`); | |||
| if (pos) { | |||
| if (pos || pos === 0) { | |||
There was a problem hiding this comment.
Do we need to add the same treatment to the other adapters like kueezBidAdapter.js, minutemediaBidAdapter.js, publirBidAdapter.js, shinezBidAdapter.js, stnBidAdapter.js?
There was a problem hiding this comment.
Yes. I would advise to check also kueezBidAdapter, minutemediaBidAdapter, shinezBidAdapter and stnBidAdapter.
I'm not familiar with (and couldn't find) publirBidAdapter, but if there any other adapters we own they would need to be updated as well
| @@ -316,7 +316,7 @@ function generateBidParameters(bid, bidderRequest) { | |||
| }; | |||
|
|
|||
| const pos = deepAccess(bid, `mediaTypes.${mediaType}.pos`); | |||
| if (pos) { | |||
| if (pos || pos === 0) { | |||
There was a problem hiding this comment.
Yes. I would advise to check also kueezBidAdapter, minutemediaBidAdapter, shinezBidAdapter and stnBidAdapter.
I'm not familiar with (and couldn't find) publirBidAdapter, but if there any other adapters we own they would need to be updated as well
| const mediaType = bid.mediaTypes && bid.mediaTypes.banner ? BANNER : VIDEO; | ||
| bid.mediaTypes[mediaType].pos = pos; |
There was a problem hiding this comment.
Since this is done to create a new bid of your choice, and not for the production logic, there's no need for logic to test the bid's media type. You can simply add the property you want for testing, as you know the object:
bid.mediaTypes.banner.pos = pos
Add support to 0 pos value in bid adapter
added tests to support pos value