Why is building:levels required to add roof:shape? [change implemented]

[legofahrrad]

To add the roof shape of a building, building:levels or roof_levels must be set. I wondered why.

StreetComplete/app/src/main/java/de/westnordost/streetcomplete/quests/roof_shape/AddRoofShape.kt

Lines 21 to 24 in cf9d62e

	ways, relations with (building:levels or roof:levels)
	and !roof:shape and !3dr:type and !3dr:roof
	and building
	and building !~ no|construction

I came across this issue when I was outside and wanted to add roof shapes but the building level quest was showing up although I gave the roof shape quest a higher priority in the settings.

Maybe someone can explain ;)
Thank you!

[Helium314]

See #2556, where this was added.
Maybe it could be different now that the quest is disabled by default.

[matkoniecz]

The question is whether it should be enabled for all buildings or for all buildings which are eligible for building:levels quest.

For example, should it be asked for building=garage?

[Helium314]

Is the roof shape any more or less valuable depending on the building?

[matkoniecz]

I expect it to be less useful to ask for example for building=garage where flat can be assumed more reliably than on building=house

Asking for building=church is more likely to result in confused mapper and answer "many different" which is not so useful.

[legofahrrad]

I would propose to ask the roof shape on the same buildings as the building levels quest.

[legofahrrad]

StreetComplete/app/src/main/java/de/westnordost/streetcomplete/quests/building_levels/AddBuildingLevels.kt

Lines 36 to 41 in cf9d62e

	private val BUILDINGS_WITH_LEVELS = arrayOf(
	"house", "residential", "apartments", "detached", "terrace", "dormitory", "semi",
	"semidetached_house", "bungalow", "school", "civic", "college", "university", "public",
	"hospital", "kindergarten", "transportation", "train_station", "hotel", "retail",
	"commercial", "office", "manufacture", "parking", "farm", "farm_auxiliary",
	"cabin"

Maybe skip "parking" as these have mostly flat roofs for rooftop parking.

[matkoniecz]

Now roof shape is shown where building levels is not yet tagged but eligible 448d05a

Not yet released. Will affect only people who changed quest order putting roof shape before building levels (or disabled building levels quest) AND enabled roof shape quest AND are not in country where roofs are usually flat.

Change not yet released, just committed.

[legofahrrad]

Great, thank you 🙂