v52.0-beta1 #4888
Replies: 3 comments 19 replies
-
|
Fix some memory leaks and crashes mistakenly links to #4887 instead of #4869. |
Beta Was this translation helpful? Give feedback.
-
|
Fixed in 3d8db79 and manually in the GitHub release description and the discussion description above. Note that it will still show up incorrectly in the changelog in the app itself in v52.0-beta1. |
Beta Was this translation helpful? Give feedback.
-
|
Regarding the attribution, you all probably know that I write It's fine when viewed on GitHub, but since contributions from other people than me became somewhat the majority of the things mentioned in the user-facing changelog, I am concerned that the changelogs become a bit cluttery to read when viewed in the "what's new" dialog within the app. I've been looking into whether the names could be replaced by the github avatars but it's either not possible or some effort (probably possible with Html.TagHandler + Html.ImageGetter + of course adding a build task that downloads the avatars and resizes them to fit) to include in the changelog text in the app. What do contributors, especially regular contributors like (in no particular order) @matkoniecz , @Helium314, @arrival-spring , @FloEdelmann , @mnalis think of the prospect that within the app, the github names would not be displayed anymore and/or the alternative with the avatar images? Be honest, i.e. speak your mind (you can also send me an email). |
Beta Was this translation helpful? Give feedback.
-
|
I don't like the idea of replacing the names with avatars: More maintenance work, (slightly) bigger app size, not as self-explanatory as user names, not reducing clutter. However, I like that people contributing code are also credited in the changelog. IMO, the current changelog is not too cluttered. But if you think it is, another option would be to credit all contributors of a version in one line below all the changes, e.g.:
|
Beta Was this translation helpful? Give feedback.
-
|
@FloEdelmann That's an interesting suggestion also, but that would mean that also here on GitHub, the contributor names would not be mentioned individually. My thinking was that in the app only, |
Beta Was this translation helpful? Give feedback.
-
|
I find situation as-is quite ok, and not too cluttered. It's not like we're having hundreds of changes per release. I seem to be social animal as much as the next guy -- getting credits, thanks, likes, supportive comments etc. gives me warm fuzzy feelings and pushes me to contribute more to get more of that positive feedback, and seeing credits of others incites me to contribute too (and helps me to subconsciously navigate virtual social hierarchy). On retrospect, I think that in early days, devs here (especially @westnordost) acceptance of random newbies and openness to their ideas (even when not in line with his thinking!), as well as explicitly expressed thanks and graceful mentioning of even the small contributions/contributors is what emitted welcomeness and has drawn me towards this specific community. So, I think that preserving that is quite more important than tiny amount of clutter in changelog (which is only read once in a while anyway). But I guess I'm probably rationalizing by this point 😸 (Also, not a big fan of the avatar idea.) TL;DR - I'd survive if it vanished, but would be happier if it stayed. |
Beta Was this translation helpful? Give feedback.
-
|
https://github.com/jens-maus/RaspberryMatic/releases/tag/3.67.10.20230225#:~:text=%F0%9F%91%AA-,Contributors,-(alphabetically)%3A for example also has a Contributors section. I am all-in for Flos suggestion with the one liner. |
Beta Was this translation helpful? Give feedback.
-
|
Okay, so let's leave it as it is |
Beta Was this translation helpful? Give feedback.
-
|
I've started using the surface overlay and already corrected a few mistakes were asphalt roads were wrongly tagged as sett. I think it would be really useful if |
Beta Was this translation helpful? Give feedback.
-
|
I'd like to see different colours for paving stones and sett. Considering so many wishes, would it be an option of the user could choose the colours by themselves? |
Beta Was this translation helpful? Give feedback.
-
|
No |
Beta Was this translation helpful? Give feedback.
-
|
What about if asphalt would get the same color as "other", i.e. just black? |
Beta Was this translation helpful? Give feedback.
-
|
That results in a map looking really ugly and depressing in cities (at least it was when asphalt was gray - I cannot imagine black being any better), though maybe "other" can take some other color. I guess that it results in losing ability to spot mistagged CLAY, ARTIFICIAL_TURF, TARTAN - but how often it happens? |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
New overlay for surfaces (#4378, #4642), thanks @matkoniecz
Now you can comprehensively map and verify surfaces mapped for roads and paths!
New Quests
Enhancements and Fixes
entrance=*#4823)toiletsis not already mapped #4866, Ask wheelchair toilets for restaurants etc. #4868, Ask toilet part wheelchair access only if wheelchair=limited #4879), thanks @arrival-spring, @Helium314This discussion was created from the release v52.0-beta1.
Beta Was this translation helpful? Give feedback.
All reactions