Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address overlay: Allow adding addresses to entrance=* #4823

Closed
westnordost opened this issue Feb 18, 2023 · 12 comments
Closed

Address overlay: Allow adding addresses to entrance=* #4823

westnordost opened this issue Feb 18, 2023 · 12 comments
Assignees

Comments

@westnordost
Copy link
Member

Oftentimes, entrances are already mapped. It would be nice if it was possible to tap on an entrance the same way as it is possible to tap on a building in order to add an address to the entrance. If an entrance has no address yet, instead just an icon of a door should be shown.

@matkoniecz
Copy link
Member

Note that entrances may have special extra fields: unit range and entrance reference.

Would it be also considered as an address?

@westnordost
Copy link
Member Author

I guess so... I mean, it would also make sense to extend the address overlay to also being able to edit this information. It is ultimately part of the address, too. But that would be a separate ticket.

@rhhsm

This comment was marked as off-topic.

@rhhsm
Copy link

rhhsm commented Feb 19, 2023

To summarise my previous comment marked as off-topic: I think addresses should be attached to buildings only, unless there is a tradition in a country to attach addresses to entrances.

@matkoniecz
Copy link
Member

matkoniecz commented Feb 19, 2023

This does not work in all cases, some documented at https://wiki.openstreetmap.org/wiki/Addresses#Buildings_with_multiple_house_numbers and https://wiki.openstreetmap.org/wiki/Addresses#Multiple_buildings_for_one_housenumber

Free-floating nodes vs tagging buildings also has no general consensus for the simplest possible case (1 address for 1 building).

@rhhsm
Copy link

rhhsm commented Feb 19, 2023

My main concern is that this quest will lead to duplication. If an address is already mapped on a building, an entrance to this building should only be tagged with a reference using the entrance reference quest.

@mnalis
Copy link
Member

mnalis commented Feb 19, 2023

Perhaps entrance overlay should not be offered for houses which already have a housenumber of them (or alternatively, it might delete housenumber from building when it is added to entrance - but that too might be unwanted) ?

@westnordost
Copy link
Member Author

westnordost commented Feb 19, 2023

Why, you can all do this manually with the overlay. No need for the quest-like smartness of only showing X when Y, just allow the user to edit everything related.

@mnalis
Copy link
Member

mnalis commented Feb 20, 2023

Why, you can all do this manually with the overlay. No need for the quest-like smartness of only showing X when Y, just allow the user to edit everything related.

I personally am I just fine with unrestricted editing functionality, it is just that SC target user group is more newbie (because of reputation and old newbie-protective old "quests" interface), and might not realize they are doing edits that will be frowned upon. While "overlay" interface is indeed geared more toward advanced users than it is to newbies (like "quests" interface is), people using SC probably still don't expect to be given JOSM/Vespucci-class freedom/responsibilities (i.e. "enough rope to hang themselves").

@westnordost westnordost self-assigned this Mar 10, 2023
westnordost added a commit that referenced this issue Mar 10, 2023
@deevroman
Copy link

deevroman commented May 6, 2023

What about countries #3064 where there is no address at the entrance? It looks strange that StreetComplete offers to add an entrance (judging by the icon on the map), but then requires an address.

@westnordost
Copy link
Member Author

westnordost commented May 7, 2023

It's the address overlay, not the entrance overlay. That an address that is a vertex of a building is usually an address is the assumption the app makes.

Regarding entrance numbers or entrance refs, the long/mid-term solution would be to incorporate the ability to add this information within the address overlay itself but I'd rather leave this to the author of the related quest, @matkoniecz , or anyone else interested in that, of course. (i.e. you can change the layout to an add-entrance-ref layout via an option in the "..." menu)

@matkoniecz
Copy link
Member

Regarding entrance numbers or entrance refs, the long/mid-term solution would be to incorporate the ability to add this information within the address overlay itself but I'd rather leave this to the author of the related quest, @matkoniecz , or anyone else interested in that, of course.

For now I want to check how it works. I have not really used address overlay so far.

(I will be likely moving soon to part of city where importance of references on entrances is even more important, so some new features would be quite likely in such case)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants