-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kerb / Curb quest surface type and tactile plates for sidewalk data #1305
Comments
I like this idea, but there are some points that will probably need to be taken into consideration.
I think the kerb ramp quest ought to be applied only to the nodes of the sidewalk meeting the crosswalk, because unlike tactile paving, there is no =no option that you can apply to the crossing node. If the kerb heights differ, there is no tag that can state that for a single node (https://wiki.openstreetmap.org/wiki/Key:kerb). The wiki page suggests using the tag on the crossing node if they are the same on both sides, but SC can't really do one or the other. Ideally, both kerb height and tactile paving would be applied to the actual sidewalk lines, not the crossing junction. It's not important to know if there is tactile paving at a crosswalk for the road users (car drivers), so there's no reason to add these tags to the road node unless there isn't a sidewalk line. In my opinion, sidewalks should be mapped anyway, and tagging just a crossing node leaves room for improvement. |
Are you suggesting that the current StreetComplete quest about tactile_paving applies the tagging to the crosswalk line itself, and not the nodes? That doesn't actually match up with the best case practices for inclusive sidewalk mapping. What we're doing is using a barrier=kerb node at the interface between the highway=crossing and the highway=footway, and specifically identifying the features of that crosswalk ramp discretely. If you assume data on both sides of the crosswalk is identical, you leave a lot of cases which become messed up, like a lowered curb on one side and a tactile plate equipped flush ramp on the other. Or where crosswalks span multiple nodes or connecting features. My suggestion for these two quests is absolutely to apply them to the type=node, and definitely not to a way/line. For your reference, take a look at this area of my town I've mapped: https://www.openstreetmap.org/edit#map=20/42.68770/-71.12140 And Nick Bolten's talk about best practices for distinct sidewalk mapping. https://www.youtube.com/watch?v=DHecYP_b3os
|
No, I definitely don't think they should be applied to lines (except when there's tactile paving along a whole crosswalk, per the wiki). I think the tags should be applied to the actual location of the ramp/tactile plate, which would be the node connecting the crosswalk and sidewalk. Your example location is exactly how I would do it. Currently, however, SC only poses the quest for tactile paving on the junction node of the crosswalk line and the road line (where in iD it's labeled Marked Crosswalk on the node). I don't like this format at all, because as you said, there are many cases where each side of the crossing is different. So to sum up, I think your suggestion is excellent, I agree with all points, and ideally, SC would not ask the quest for the junction on the road, but at the edge of the sidewalk, where it matters to pedestrians. Incidentally, other quests asked for the crossing node on the road include what type of crosswalk it is (marked, unmarked, etc.), whether there are sound signals for the blind, and whether there are buttons to change the light. I think all of these quests are fine on the road junction node. |
Oh, okay, I see what you were saying. Yeah, there's not really a good reason to apply tactile_plate at the junction between the crosswalk and the car roadway line. That's definitely not how it appears in the real world... |
I think the reasoning for how it is right now is that otherwise crossings without the actual line data for the sidewalk network would not have any information about tactile paving. |
I don't think searching for barrier=kerb would be adequate, but here's an Overpass query for the interfaces between sidewalks and crosswalks: [bbox:{{bbox}}]; /* Add this for some coloring */ |
Why do you think that searching for I tried out your query and got this: http://overpass-turbo.eu/s/F0T |
Searching for Either (any) option relies on previously correct mapping in some form or another. The crosswalk tag could be left off, and the quest wouldn't find those nodes. The kerb barrier might not be mapped. Or the crossing way might be in the wrong spot. But based on some quick spot checks in Overpass, the query goldfndr posted seems most promising. |
My point was that with @goldfndr query + asserting that the found nodes must have |
By my understanding of the wiki, I think in practice, a |
Hi, Just joining this discussion, I am not sure what was the conclusion of this discussion so here is my 2 cents.. I too think this quest (about kerb) would be super interesting to implement. |
|
I would include |
missing! Photo with lowered curb without ramp. (also for missing: decent photo for Hopefully someone will manage to find good picture (frontal view from street) or there will be at least one day with a good light this Autumn in Kraków and I will be able to take a photo. |
better a picture of a concrete curb, stone is really rare and might be confusing. Or, maybe better an icon that just shows the profile? |
I am not entirely sure whatever profile icon would be clear to people - technical and semi technical drawing are surprisingly often not understood by people. |
mh ok |
Hi all,
|
Adding resurvey of old
See https://wiki.openstreetmap.org/wiki/Key:kerb - photo example for |
This is really confusing to me. |
Maybe. In this case I see this ramp as being a kerb ("dropped kerb") - https://wiki.openstreetmap.org/wiki/File:Dropped_kerb.jpg And it is still a bit of a barrier due to its slope. Mixing "kerb but low" and "kerb ramp reaches road surface but is quite step" in If anyone is interested in proposing new tagging for distinguishing "dropped kerb" and "low kerb but still not 0" then, once such tagging would be accepted (via accepted proposal or by some minor but noticeable use and being documented at wiki) I would gladly use it. Also, if Wiki is wrong then it should be fixed, but from what I see that tagging practice is accepted. |
I will need to look at it a bit more, but it seems that this quest will be the first to add tags to OSM objects that had no tags before the SC edit :)
|
Dang! I fixed it |
Yes, the top kerb and the bottom kerb.
The mapper stops its mapping, there is not another specific reason for the interruption.
This is the schema decided, the part between the kerb and the sidewalks is part of the crossing. Here an example image inserted in the wiki, with the colours that shows the crossings and the sidewalks. |
Yes, that is case mentioned in #1305 (comment) (incomplete mapping) with added bonus of defining that crossing doe not end on kerb and mapping that kerb - despite not mapping sidewalk connection to East/North. |
And thanks for link, now I understand what happened. Not sure yet what should be done with that. |
The mapping was consistent as explained in the wiki about the project following the different rules of mapping. I don't know if the way this is mapped is as defined as:
But I believe that it is not correct that the app adds new nodes with the attributes of the kerbs where these elements are already existing. For me, it should check if other nodes in the crossing have the attributes |
Checking tags of given node is easy, checking tags and count of attached ways is doable, checking tags on nodes of nearby ways is hard to do. |
Not nearby, but nodes in the same way of the crossing. Is this not just recursion? |
If it is OK to fail on split ways - yes.
https://github.com/streetcomplete/StreetComplete/blob/master/app/src/main/java/de/westnordost/streetcomplete/quests/kerb_height/AddKerbHeight.kt#L15 but most of checks is in https://github.com/streetcomplete/StreetComplete/blob/master/app/src/main/java/de/westnordost/streetcomplete/quests/kerb_height/KerbUtil.kt |
Also, that would break asking for kerb info if one if two kerbs on crossing is mapped already. |
I read up on this thread and came to the conclusion that I think nothing needs to be changed in StreetComplete. I'll explain whySo it seems, that both and are accepted / in use schemes to tag a crossing with kerbs. Option (b) with either a single way that connects the two sidewalks or several connected StreetComplete asks mainly for kerb properties for nodes that are either
Additionally, it detects situations where an implicit kerb can be assumed, but only if the crossing is mapped like in situation (a). It specifically excludes situation (b) as to not set a The situation as depicted here One can use the One example how to do it correctly is here: Edit: Using that intersection as an example to show why stopping to map an intersection in detail at that point is really wrong / problematic for data consumers. Imagine the sidewalk-footway on the upper left of that picture would be missing and instead |
I also thought about how to detect the presented situation of an incompletely mapped intersection reliably, but there is none that I can see:
|
So, in case of incomplete data StreetComplete may do something dumb and may require a bit of cleanup from someone completing sidewalks. But in this case it would require that at the same (1)
Or (2) If there is consensus among Italian community that such behavior of StreetComplete is unspeakably evil then the entire quest can be disabled in Italy. But I am not going to implement filtering out such cases as it would disable also places where quest is legitimate. |
@matkoniecz I don't understand (2). Can you illustrate, maybe both points if they haven't yet? |
Well, fact is that the app is adding incorrect data, which is not good. However, my point earlier was that it is only adding incorrect data because the data it worked on was already incorrect. This makes it less bad, especially as the mistake can easily be corrected when the road is mapped further (the sidewalk-mapping is being continued) later. |
#1305 (comment) - StreetComplete added inner kerbs despite outer kerbs being present already. |
I agree, but I think that disabling quest on request from local community is OK. Even if the quest works perfectly fine. As long as it is an actual consensus, not a single person complaining. |
Hm sorry, I don't understand this illustration. The background imagery is so blurred that I don't understand what is the real world situation here and I also don't know what the icons and the slightly different colors of the lines stand for. |
Right, understood. I see no problem to use |
I add the idea of the tagging schema chosen here. I'm not sure to the use of the |
Not depending on the type of mapping decided, I found an error. The app proposed the quest for all the nodes that satisfy the characteristics requested, so if in a crossing there are nodes tagged as Here an example in the app: The nodes (1) and (4) are the junction with the way mapped as the sidewalk, instead, (2) and (3) are mapped with |
Ehm, I have the impression we are going in circles. Maybe there was a misunderstanding due to the language barrier. I'll try to make it clear: Here is the linked situation with labels. I painted the kerb line you assumed onto the screenshot in grey since the photo resolution is so bad. I assume the answer to that is because you map with this scheme: Fair enough. But then, please mind what I wrote in the comment above: #1305 (comment) . You must lead the sidewalk back to the street with such "helper lines" at the points where you stop the detail-mapping of sidewalks, otherwise data consumers will not be able to ascertain the sidewalk situation correctly / route pedestrians correctly. I explained it in more detail why this is the case in the linked comment. The last two pictures in that comment should be informative. |
Yes, but if you think in the case of a street. Two street are mapped as (a) or (b)?
This is wrong, in that street, there are no sidewalks.
And what is the meaning of the triangle? It is not needed, the router will use the crossing to reach the street and after will use the road, if needed. So the triangle represents somethings that do not exist and it is useless for routing. Hoping to close this part, I believe that both the schema are suitable, my last question is why the app asks for attributes on external nodes when there are already nodes in the way with the tag Sorry, for all these long comments, but I think that the mapping with the StreetComplete app is very suitable and useful for people with physical disabilities, and I would like to propose this solution to them for the mapping. |
Ok, I didn't know that. But in that case , it makes no sense to map it like that because if there is no sidewalk in the road going North, the piece of sidewalk beyond the kerb should not be part of the crossing by any definition (neither (a) nor (b) in above examples). It should look like this: |
Ok, so I ask you sorry. |
Ehm, I am not sure if I undestood your comment. First picture: Streetcomplete asks for the kerb type for the blue squares |
I am suggesting here two quests related to inclusive pedestrian mapping as defined in https://wiki.openstreetmap.org/wiki/Sidewalks. This has the potential to affect a large amount of kerb ramp data in a positive way.
General
Define what type of kerb interface a crosswalk has to a sidewalk
Affected tag(s) to be modified/added: [kerb=] https://wiki.openstreetmap.org/wiki/Key:kerb
Search for type=point ; barrier=kerb, which should define a single node on a highway= segment
Ask "How high is this kerb ramp?"
Answers: flat ; lowered ; raised
Ask if a kerb ramp has a tactile plate that would be used by the blind
Affected tag(s) to be modified/added: tactile_paving=*
Question asked: Does this kerb ramp have a tactile plate for the blind?
Answers: yes ; no
Checklist
Checklist for quest suggestions (see guidelines):
Purpose is to enhance the inclusive pedestrian network tagging through revision of kerb ramp data to enhance overall accessibility for patrons requiring accessible infrastructure
Tags are well defined for both quests proposed.
With the proper graphical elements in the displayed quest, this would be answerable by anyone.
These are roughly boolean options, and so many will have the same answer, but I wouldn't consider this spam, rather, completion of features that should be documented for proper routing.
Has the potential to improve a vast amount of kerb ramp data.
Ideas for implementation
We should use graphical depictions of the kerb ramp heights to show people what the different types are. There's very good graphics available on the Key:kerb page for each option.
We should also use a graphic to show a tactile plate, so people know what it is when asked.
The text was updated successfully, but these errors were encountered: