Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addr:housenumber quest is not asking for addr:street #205

Closed
matkoniecz opened this issue May 9, 2017 · 19 comments
Closed

addr:housenumber quest is not asking for addr:street #205

matkoniecz opened this issue May 9, 2017 · 19 comments

Comments

@matkoniecz
Copy link
Member

Addresses are complex topic but at least in Poland just addr:housenumber is not very useful without addr:street.

addr:street data may be easily collected at the same time as adding addr:housenumber without second trip once missing data is discovered.

see for example https://www.openstreetmap.org/changeset/48476823#map=19/50.07902/19.88515 where somebody else is complaining about incomplete edit made using StreetComplete

@krzyk
Copy link
Contributor

krzyk commented May 9, 2017

Besides addr:street also addr:city and addr:postcode is required in some countries.
So it would be good to have possibility to add it (preferably with a prefilled values based on the surrounding addresses)

@westnordost
Copy link
Member

westnordost commented May 9, 2017 via email

@westnordost
Copy link
Member

westnordost commented May 9, 2017 via email

@matkoniecz
Copy link
Member Author

matkoniecz commented May 9, 2017

a surveyor cannot determine the name of the street because street sign are only at intersections

In Poland it is typical that housenumber sign includes street name. Also, in cities intersection are really dense so it is trivial to add this info.

https://duckduckgo.com/?q=tabliczka+adres&t=canonical&iax=1&ia=images

images duckduckgo com

streetview example: https://www.google.com/maps/@50.0780279,19.8802301,3a,25.7y,95.62h,89.97t/data=!3m6!1e1!3m4!1sFmfhHTjDQsXhG2xR2eOx2g!2e0!7i13312!8i6656

(how one may resize images in the issue?)

@matkoniecz
Copy link
Member Author

In addition survey is necessary in many cases to complete addr:street as it is possible that correct addr:street is not the name of the nearest street - and for houses near intersection it fails completely. For example http://www.openstreetmap.org/?mlat=50.07773&mlon=19.87955#map=19/50.07773/19.87955

selection_001

this house has decent chance to have following addr:street values: Filtrowa, Na Błonie, Zarzecze. It is much less likely but possible to have yet another addr:street. Adding addr:street here requires either import from official data or survey.

@krzyk
Copy link
Contributor

krzyk commented May 9, 2017

I agree with @matkoniecz that figuring out the street name for given housenumber only in JOSM is not trivial (there are multiple strange cases there, e.g. I lived on a street that was on a border between cities, and the street name was different than my address street name).

I also agree that postcode and city is easy enough to fill out in the JOSM so there is no point in adding it here.

@westnordost
Copy link
Member

westnordost commented May 9, 2017

I am not convinced yet that it makes sense to determine the street name of any one address while on the survey. Do you have any examples where it would be only possible to determine from a survey or at least be easier than remotely with JOSM?

@matkoniecz example actually serves as an example why mapping which house belongs to which street does not make sense on the survey. From the map, you can easily see that housenumber 36 belongs to Na Błonie by following the string of other mapped housenumbers. This is something that would be much harder to realize when you were actually in the field* as it seems the house should be in Filtrowa.

*talking internationally here, in most countries the street name is usually not on each housenumber plate

@Etua
Copy link
Contributor

Etua commented May 9, 2017

Still it is possible to add such possibility not as an obligation especially when combined with name suggestions as iD does for the new points right now.

@krzyk
Copy link
Contributor

krzyk commented May 10, 2017

@westnordost A common problem is for houses that are near intersections of roads.
Here's an example: http://www.openstreetmap.org/way/431448745

This house is on the intersection, and without survey you wouldn't know which street it belongs to. And from the satellite photo you might think it is on Rezerwistów (because it has a driveway to the garage from that street), but it actually belongs to Na Czekaj street.

Another example near the previous one: http://www.openstreetmap.org/node/3302999187
This one is again near intersection and belongs to one street (and again, has driveways from both streets).

As for which housenumber plate and street name, https://www.google.pl/search?q=house+plate&safe=off&client=firefox-b-ab&source=lnms&tbm=isch&sa=X&ved=0ahUKEwiy_6Kx0uTTAhVMVSwKHYGjAhwQ_AUICigB&biw=1600&bih=768 suggests that both approaches are popular so it is hard to tell which one is more popular.

@matkoniecz
Copy link
Member Author

Do you have any examples where it would be only possible to determine from a survey or at least be easier than remotely with JOSM?

See #205 (comment)

For real case see http://www.openstreetmap.org/?mlat=50.07780&mlon=19.88089#map=19/50.07780/19.88089 (I added housenumber with StreetComplete, now I need to resurvey to check whatever it is Zarzecze, Na Błonie or something else).

@matkoniecz
Copy link
Member Author

selection_002

What is addr:street here? It is not the nearest street, blind editing with JOSM would result in tagging addr:street=Słowicza, different from the current tag (http://www.openstreetmap.org/node/1915399183#map=19/50.08655/19.89851).

@matkoniecz
Copy link
Member Author

From the map, you can easily see that housenumber 36 belongs to Na Błonie by following the string of other mapped housenumbers.

The problem is that this heuristic generally works but given complexity of adddr:street making "I guessed this addres data" edits is not acceptable (maybe in say USA addresses are much less likely to be highly surprising but in Poland weird and surprising address situations are normal).

@matkoniecz
Copy link
Member Author

matkoniecz commented May 10, 2017

Or another surprising one

selection_003

It has addr:street that is neither Racheli nor Złoty Róg. Nor Błażeja Czepca.

http://www.openstreetmap.org/way/230244928#map=19/50.08120/19.89578

@HolgerJeromin
Copy link
Contributor

I think we can summarize that there are situations where a survey is needed and some where an overview is needed.
This house has no street name on the wall. I had to guess from the surrounding numbers that it does not belong to Narzissenweg.
image

So a drop down with surrounding street names with the default "do not set/change" is probably the best solution.

@westnordost
Copy link
Member

westnordost commented May 10, 2017

@HolgerJeromin and @matkoniecz: Wait, are you arguing for or against adding a street name field? Because all your examples work as examples for that the heuristic of following the string of housenumbers (from looking at the map) works better than trying to find it out on the survey. 😕??

The two examples from @krzyk, though, are wicked, there the heuristic does not work. But again, we are not talking exclusively about Poland here, so we cannot assume that the street name is given on all the house number plates. So, even when the surveyor is looking at the street signs, he would still probably get it wrong or would not be able to answer this.

But why am I even arguing against having this input field since there are certainly cases where it makes sense to add the street name if the surveyor knows it? Because it has some downsides, obviously, so I need to balance that. Here are reasons that weigh on the other side of the said balance:

Would make form more complex

The forms, though, should be as easy as possible. There was already some confusion regarding the building levels quest because it has two fields.

  • the form must scroll to accomodate a second street name input. As soon as the form needs to scroll, it becomes much more cumbersome to quickly click through (see surface quest and the X open issues I have for that). Being able to quickly click through is a very important feature for a quest such as housenumbers is very important for usability.
  • it must explain in clear words that to enter a street name is optional, further blowing up the form. Still, many users will want to fill out the street name right away if it is part of the form. I foresee that would give me a lot of complaints that entering housenumbers is too time-consuming, leading to feature requests like "auto fill in closest street name" which I naturally need to decline since this may lead to wrong data as we see through the examples here

Optimize for the common case

In general, the quest forms should be designed in a way that it is easy to input it for the common case hile not making it impossible to input for the edge cases

  • Leaving out the street name of this input altogether does no harm because it does not make impossible that a street name is added later.
  • What would make it impossible or at least much more difficult (to detect), was, if a wrong street name is entered. Since with a street name input, the street names would be sorted by distance, there would be the danger that the user prematurely chooses the street closest to him as experience showed to him this is correct for pretty much all of the cases. We know by the examples brought up here that sometimes, this is not correct. Expecting the user to always be very cautious and double check an information he cannot possibly quickly check without looking at the big picture, is unrealistic, to say the least!
  • A street name input is only warranted through the few edge cases where street names can not be simply determined from looking at the map, which applies to the vast minority of house numbers. For edge cases that are not covered via the "Other Answers..." button, there is always as you know the "leave note" button.
  • Did you know that notes that are formulated as questions (contain a "?") are displayed to StreetComplete users as quests?

Implementation effort

  • adding the street name input (as dropdown of near streets) requires more implementation effort and more overpass queries done:
  • the implementation effort is not to be underestimated, since the app needs to store the surrounding street names for each housenumber persistently in local storage and clean this up when quests are solved. Finally, it needs to show the street names sorted by distance to the building (possibly distance between multipolygon and long linestring). Neither of that is trivial.

Workflow

  • assuming an area where previously no housenumbers were inserted, a pattern which house belongs to which street only becomes apparent after the survey

My proposal for these kind of edge cases presented by @krzyk are to write a note at the position of the building after street names have been entered through JOSM, asking something like: "to which street does this house belong?".
This note will then appear in the StreetComplete application as a quest, asking the user to contribute to the note. He can then set out to clear up that one edge case.

@krzyk
Copy link
Contributor

krzyk commented May 10, 2017

@westnordost Makes sense. But I have a follow up, wouldn't it be a good idea to add a separate quest for adding street names to addresses that already have housenumbers? This would leave only the implementation effort from the above list.

@westnordost
Copy link
Member

westnordost commented May 10, 2017

This would at least the better option than to squeeze it in one quest. However, the point about the implementation effort still applies.

If there was such a quest, I would limit it to housenumbers 1 and 2.

I suggest to create a new issue for that, link that issue to this one and close this one.

@HolgerJeromin
Copy link
Contributor

Did you know that notes that are formulated as questions (contain a "?") are displayed to StreetComplete users as quests?

Wow.
We really need a documentation for the magic of the quests :-) containing a string is surprising. I thought every note was presented here
#194

I understand your work flow issues with adding the street name.
Perhaps the street name is better filled in vespucci which leads me to: Using geo intends #190

@matkoniecz
Copy link
Member Author

matkoniecz commented May 10, 2017

I suggest to create a new issue for that, link that issue to this one and close this one.

OK - see #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants