Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide extra info allowing to identify specific object such as bicycle parking #4058

Closed
matkoniecz opened this issue May 24, 2022 · 9 comments

Comments

@matkoniecz
Copy link
Member

matkoniecz commented May 24, 2022

Use case
Sometimes there are multiple bicycle parkings next to each other (wheelbender and proper stands). In such case asking about bicycle parking capacity is impossible to answer.

getHighlightedElements is not helping in case when parkings are directly next to each other.

And yes, it is an actual problem and I run into it.

Current label is

Bicycle Parking

or

Operator Name (Bicycle Parking)

I propose it to become

Bicycle Parking - wheelbender

or

Operator Name (Bicycle Parking - wheelbender)

Proposed Solution

Show bicycle_parking tag (translated using text from bicycle parking type quest)

Opening an issue as I suspect that @westnordost may veto this due to worry that getNameAndLocationLabelString may start growing more complex.

Though I think that it is worth it.

@matkoniecz matkoniecz changed the title Provide extra info allowing to identify specific object such as bicyle parking Provide extra info allowing to identify specific object such as bicycle parking May 24, 2022
@westnordost
Copy link
Member

westnordost commented May 24, 2022 via email

@matkoniecz
Copy link
Member Author

Your use case could be solved by displaying different Icons for different types of bicycle parkings? If yes, which bicycle parkings would need to be distinguished?

The problem is that sometimes parking are next to each other and icons are too close to be distinguishable.

What worse, if mapped as nodes it is not possible to distinguish them just from positions, and different mappers would place them differently. Often making nonobvious which refers to which one.

Following one is case which I encountered multiple times, decent parking and whellbender next to each other:

5884_img1_47b34ad453e8e803593a5ade114bb0c8

@FloEdelmann
Copy link
Member

Why not modify the title of these quests to include the translated iD preset?

E.g. How many bicycles can be parked here?How many bicycles can be parked here (%s)?

@westnordost
Copy link
Member

Why not modify the title of these quests to include the translated iD preset?

E.g. How many bicycles can be parked here? → How many bicycles can be parked here (%s)?

Is it 2021 again? The translated iD preset name is already displayed below the question! Don't you remember, we change this?

@FloEdelmann
Copy link
Member

The %s should then of course be filled with "wheelbender" or "stands", which is not yet part of the iD preset name.

@westnordost
Copy link
Member

Nah, don't want to have (temporary) workarounds like that.

@westnordost
Copy link
Member

To summarize:

  • different icons don't really work if the nodes are really close to each other
  • but displayed names (OP suggestion) also don't work in that case
  • I do not want to have temporary workarounds like suggested by Flo

Hence, the solution should be that the bicycle parking subtypes should be iD presets. In the meantime, leaving notes should be just fine.

@matkoniecz
Copy link
Member Author

the solution should be that the bicycle parking subtypes should be iD presets

not entirely sure, iD can more or less distinguish it and there is no need to change feature name

screen01

(translatable names of types would be even better but that is kind of separate issue)

@westnordost
Copy link
Member

It is possible to have presets that add several tags at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants