Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New quest: valve types on bicycle pumps #4450

Closed
5 tasks done
Sukkoria opened this issue Oct 2, 2022 · 6 comments · Fixed by Helium314/SCEE#644
Closed
5 tasks done

New quest: valve types on bicycle pumps #4450

Sukkoria opened this issue Oct 2, 2022 · 6 comments · Fixed by Helium314/SCEE#644
Labels
feedback required more info is needed, issue will be likely closed if it is not provided wontfix idea rejected because it is out of scope or because required work is not matching expected benefits

Comments

@Sukkoria
Copy link

Sukkoria commented Oct 2, 2022

General

Affected tag(s) to be modified/added: valves=
(described on amenity=compressed_air)
Question asked: What kind of valves are compatible with this pump?

Checklist

Checklist for quest suggestions (see guidelines):

  • 🚧 To be added tag is established and has a useful purpose
    -> I think it will be useful for cyclists and other riders of small vehicules with tires (e-scooters…)
  • 🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)
  • 🐿️ Easily answerable by any pedestrian from the outside but a survey is necessary
    -> in my neighbourhood, the valve types are noted and drawn on the pump, there’s no need to inspect the pump output and recognize the valve type by eye (+ photos can be provided in the quest in this case)
  • 💤 Not an overwhelming percentage of quests have the same answer (No spam)
    -> based on the existing values in taginfo, the values are varied
  • 🕓 Applies to a reasonable number of map data (Worth the effort)
    -> There are currently 985 items using valves=… in OSM and ~ 9k service:bicycle:pump + ~ 7k amenity=compressed_air, so there are items that could be improved?

Ideas for implementation

Element selection:
amenity=compressed_air or service:bicycle:pump without the key valves
overpass-turbo request

Metadata needed:
No idea on this point; my observations are based on what I’ve seen in France.

Proposed UI:
To make easier to identify the valve type, I was thinking of a UI with photos (like the one to add surface types), using pictures like in the wiki if the license is suitable, or pictures from wikimedia commons.

If this type of quest is OK, I would gladly develop the matching code during Hacktoberfest, or other simple quests depending on what is available from the Issues list.
Have a nice day and feel free to tell me about your insights on this one!

@matkoniecz
Copy link
Member

matkoniecz commented Oct 2, 2022

In Poland two walve types are in use and bicycle pumps universally have both. Is situation different in France? Or elsewhere? And there is walve in use that is compatible only with some bicycle pump stations?

@matkoniecz matkoniecz added the feedback required more info is needed, issue will be likely closed if it is not provided label Oct 2, 2022
@slackline
Copy link

In the city I live in the UK the pumps that haven't been vandalised also have two types of valve (Schrader and Presta). There are other valves such as Dunlop (also known as Woods) and Tubeless valves for wheels without tubes but I've personally never used inner tubes/bikes that require these. Useful article on the types of bike valve and there is still scope for more variation elsewhere in the world.

@westnordost
Copy link
Member

This is likely something that requires some "expert" knowledge. Not even people who own a bike may tell apart exactly how the different valve types look, and even less like a compatible bicycle pump would look. Off-the-shelve bicycle pumps (which may be found chained to the door of a bicycle shop etc.) also usually have it not labelled. Maybe they would have it labelled with what they are compatible with on the packaging, but obviously, public bicycle pumps have their packaging removed.
Same with air compressors at fuel stations. They'll most probably only support Schrader (=car valve) because they are not made for bikes, but many do actually not know this. So, this is already reason enough to not have this as a quest:

👨‍💻 Users are no experts
🐿️ Easy answer

Additionally, it is likely that every public pump will support anything that is common in whatever region the bicycle pump is situated. So, the data recorded will usually not be surprising and if it is surprising, I estimate that quite a high percentage of that would actually be input wrong (due to "👨‍💻 Users are no experts")

💤 No spam

@westnordost westnordost closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2022
@mnalis
Copy link
Member

mnalis commented Oct 3, 2022

(related: discussion in #3053 (comment) and below)

@mnalis

This comment was marked as resolved.

@mnalis mnalis added the wontfix idea rejected because it is out of scope or because required work is not matching expected benefits label Sep 12, 2024
@mnalis
Copy link
Member

mnalis commented Sep 12, 2024

(fixing closed status / tags; as this was implemented in SCEE only, and is wontfixed in StreetComplete)

@mnalis mnalis closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback required more info is needed, issue will be likely closed if it is not provided wontfix idea rejected because it is out of scope or because required work is not matching expected benefits
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants