-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AddBicyclePump, for bicycle_repair_station. Adding only pump #5870
Comments
why you think so?
well, in such case the same was also implied earlier
Iff it makes sense to have it also such way in iD then it can be added https://github.com/openstreetmap/id-tagging-schema Or is it maybe already possible in iD? (StreetComplete is using iD presets) |
the wiki says so, see service:bicycle:tools
It is not, but I think it is also less necessary in iD since the user can set the tool tag manually here. |
Hmm, in the worst case SC does not make things more clear - if
Then SC mapper adding |
If new quest asking about (see https://github.com/streetcomplete/StreetComplete/issues/new?assignees=&labels=&projects=&template=quest-suggestion.md - note that I have not checked is it fulfilling this requirements, I suspect that it fails "no spam" as vast majority of this stands has tools) |
I agree, however I do feel like more, very useful, information could be easily added via the "only" suggestion.
Hmm I am not so sure, in my experience, sole bike pumps are a bit more common, and currently around 40% are tagged with tools while almost 60% are tagged with pumps, but I guess that would be a discussion for another thread. |
That wouldn't really help with already existing bicycle_repair_stations, though. (there is a Thing for
Might work, although IMHO that would be somewhat confusing, given the quest already asks only about "Is there a working bicycle pump here?" (and not about tools, stands etc). Perhaps wording might be changed? Some other options:
Now, if this was SCEE, I'd personally definitely go for However, This being StreetComplete and taking into consideration "👨💻 Users are no experts" and "🐿️ Easy answer" quest guidelines, I'd probably go with What do people think? |
Bicycle pumps can be added to the things overlay as soon as there is a iD preset for that. For the iD preset, you'll have to open an issue or PR over there. I like @mnalis suggestion to create a new quest that asks for all features of a bicycle repair station. Personally, I don't have such an issue with |
TL;DR: make sense to me, we can also include If other people would help find representative and appropriately licensed photos for As for the `chain_tool`, here is rationale [click to expand]
As a mostly trekking/touring bicycle rider, that did strike me as odd too, but apparently (especially at MTB community) chain snapping is very frequent occurrence (to the point that at the courses here that is the second thing they teach; after replacing the punctured tire).
Probably because it is relatively often useful, but not always included (for this region I'd venture to guess that non-inclusion is because it is most likely to get stolen, as many bicycle users don't have it at home [as opposed to screwdrivers / wrenches] and, a specialty tool, it is more expensive then those). From the OSM side, people found it useful enough to tag it several thousand times and document it on the wiki separately, and to single it out at 11.57% of the places with general tools, so that sounds good enough for me for inclusion (even if I'm not a target user)
The screewdrivers, wrenches, and tire levers are included in all service stations I've seen... Spoke tighteners often aren't, but probably those are not field-critical -- you can get home with slightly untrue wheel, but you can't without a chain or with a flat tire. Also, while truing the wheel is possible without special stand, it is not easy, require significant expertise, and is very time consuming (and often might require few new spokes).
I agree, but I've never seen replacement parts being given for free. In tourist heavy places, there might (very rarely) be an additional
Actually (unless you run pully-less system), you can often fix a chain by shortening it for a link or two (or even more if you give up shifting speeds). Even for my pully-less integrated Shimano Nexus shifter (using single-speed chain), I could survive chain snapping and resulting single link loss (not that it had ever happened to me, but than again those single-speed chains are robust monsters compared to even 10/11-speeds ones, not to mention those thin 13-speed) . |
For such a quest, I still would find it meaningful to first ask in the community forum if there are other popular or sought-after features of a bicycle repair station should be selectable. |
So, anyway, would you create a new issue in the form of a "new quest suggestion" for this, please? |
|
As sugested I have opened an issue for this preset here: openstreetmap/id-tagging-schema#1339 |
The results AFAICT seem to be in favor of current selection of There were some mentions of few other undocumented tags in use (like It was also mentioned that such The discussion then veered in direction of separate valves (and Schwalbe Clik valve in particular) quest (to be asked if
(I'll open one shortly and reference it here.) |
Alright, would you pour this information into a new quest suggestion? Then this issue can be closed. |
(Ok, created new quest suggestion with template in #5910, closing this issue as duplicate...) |
Use case
A standalone bike pump is usually tagged as
service:bicycle:pump=yes service:bicycle:tools=no
the latter being assumed to be yes by default. However this currently seems impossible to tag in the app, as the pump can be added, and using the AddBicyclePump the pump tag can be set, the tools tag can not be set to no, thus incorrectly implying that this pump also provides tools.
Proposed Solution
The text was updated successfully, but these errors were encountered: