Add amenity driving_school in AddOpeningHours quest

[bmaggi]

Use case

• when mapping StreetComplete should (IMHO) propose to add opening hour to driving school (In France, driving_school propose theoretical training and have opening hours for that)

Proposed Solution

• add driving_school here https://github.com/streetcomplete/StreetComplete/blob/master/app/src/main/java/de/westnordost/streetcomplete/quests/opening_hours/AddOpeningHours.kt#L46

⚠️ This issue suggest that at some point (old java version) driving_school was already present in this quest (but it's not present at the start of the kotlin file)

I can push a MR if this change is accepted

[matkoniecz]

So when they were removed? See https://github.com/streetcomplete/StreetComplete/commits/4fe712c3e112c178bc10e54df6623f78083ad47b/app/src/main/java/de/westnordost/streetcomplete/quests/opening_hours/AddOpeningHours.java

And https://github.com/streetcomplete/StreetComplete/commits/master?after=1c1b4240f8433664fafc32c257dd4c25fc2fe85c+69&branch=master&path%5B%5D=app&path%5B%5D=src&path%5B%5D=main&path%5B%5D=java&path%5B%5D=de&path%5B%5D=westnordost&path%5B%5D=streetcomplete&path%5B%5D=quests&path%5B%5D=opening_hours&path%5B%5D=AddOpeningHours.kt&qualified_name=refs%2Fheads%2Fmaster

---

removed in 1177bf2#diff-5c7180b33baf57242cd55ed607859ebcc48fc99a71b6d66b1cc1dacebead6b76

seems not added in 1177bf2#diff-65f305a6c04e72dd0948cb22f28c60f1c671ed685f0dc366cde996243bca25bf

[matkoniecz]

I would say that adding it back would make sense, as far as I can see, seems to be accidentally gone when converting to Kotlin. It may be worth checking whether anything else got lost in opening hours quest.

Feel free to make PR, just test whether it works. Thanks for spotting it!

[bmaggi]

Here is the PR. I didn't test locally for the moment (I have to reinstall the android studio since my version is too old, will try to do it tomorrow)

Note that "horse_riding" also disappeared without explicit explanation but was probably included in this comment L 76
// not sports_centre, dance etc because these are often sports clubs which have no
// walk-in opening hours but training times