Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An invisible note interferes with road selection in overlay mode #5324

Closed
deevroman opened this issue Oct 19, 2023 · 13 comments
Closed

An invisible note interferes with road selection in overlay mode #5324

deevroman opened this issue Oct 19, 2023 · 13 comments

Comments

@deevroman
Copy link

How to Reproduce

  1. Enable Surfaces overlay
  2. Move the map here
  3. Click on the sidewalk
  4. Opens a note that is located nearby
2023-10-19.21.21.57_2.mp4

Expected Behavior

  1. The sidewalk surface editing window opens

Versions affected
StreetComplete 54.1, Samsung Galaxy A52 Android 13 OneUI 5.1

@deevroman deevroman added the bug label Oct 19, 2023
@westnordost
Copy link
Member

westnordost commented Oct 19, 2023

Jup, duplicate, not a bug

@westnordost westnordost closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2023
@westnordost westnordost removed the bug label Oct 19, 2023
@deevroman
Copy link
Author

  1. But if the note is not relevant to the selected sidewalk? For example, in this one I reported a missed footway, not a problem with the sidewalk.

  2. Why not write about it in the interface?

@westnordost
Copy link
Member

StreetComplete cannot know if it is related to a specific quest or overlay or not. So, the most cautious approach is to let notes block all other edits with StreetComplete.

@deevroman
Copy link
Author

deevroman commented Oct 20, 2023

Notes left as a result of a quest start with "Unable to answer ..." or Overlays "In context of overlay..." and contain the id of the object.

But why all this complexity when I can switch off overlay and add surface with a quest? :)

@westnordost
Copy link
Member

You cannot add surface with a quest while a note is open for that element.

@deevroman
Copy link
Author

I.e. in the case of a quest it is clear what the note refers to, but in the case of overlays it is not? Why?

@westnordost
Copy link
Member

Sorry, I don't get what you mean.

@deevroman
Copy link
Author

deevroman commented Oct 20, 2023

I'll try to show what the contradiction is with an example:

2023-10-20.14.51.33.mp4

What's more, the note doesn't even belong in the selected footway. It is added, via long press on the main screen, separately from the quest or overlay.

@westnordost
Copy link
Member

Oh, that's a bug. The quest should not be created, i.e. overlay and quest should behave the same. Would you mind creating a new issue for htat and share the location where this is happening?

@deevroman
Copy link
Author

deevroman commented Oct 20, 2023

in the first comment

@deevroman
Copy link
Author

Created. But I would like to point out that the bug is more about opening a note that is not related to the selected object :) I don't understand when it's important to prevent the user from answering a quest because of some other note.

@Helium314
Copy link
Collaborator

see also #4700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants