Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "it is a garage" option for housenumber quest #767

Closed
matkoniecz opened this issue Jan 14, 2018 · 10 comments
Closed

add "it is a garage" option for housenumber quest #767

matkoniecz opened this issue Jan 14, 2018 · 10 comments

Comments

@matkoniecz
Copy link
Member

Sometimes building value are not correctly set. From looking at OSM notes it seems that the most common mistake is garage tagged as a residential building.

Maybe making possible to fix it directly in SC would be a good idea?

example of note: https://www.openstreetmap.org/note/1267738

@matkoniecz
Copy link
Member Author

If other cases of mistagged buildings are common it may be also worth adding them.

@westnordost
Copy link
Member

Or perhaps rather_It has no housenumber_ -> Opens dialog, which asks why not. There are then several answer options, one of them would be "It is not a kind of building where one would expect it to have a housenumber" (or shorter somehow).

@matkoniecz
Copy link
Member Author

"It is not a kind of building where one would expect it to have a housenumber" would retag it to building=yes, right?

I think that it may be also an option but direct retagging to building=garage also should be available (for some reason it is quite common tagging issue).

@westnordost
Copy link
Member

Well, that is an option. But I thought it would open the notes dialog in which the user is prompted to explain what building it is then.

When the building quest is implemented, that prompt could be replaced by using the same UI as the building type quest.

@matkoniecz
Copy link
Member Author

user is prompted to explain what building it is then.

Is it then used to create note anyway? Main benefit of what I proposed is that it edits directly rather than creating a note.

When the building quest is implemented, that prompt could be replaced by using the same UI as the building type quest.

That is probably the best solution.

@westnordost
Copy link
Member

Is it then used to create note anyway?

Yes, the goal would be to make it clearer to the user what to do (and what information to provide), not to avoid notes.

@rugk
Copy link
Contributor

rugk commented Jan 14, 2018

Main benefit of what I proposed is that it edits directly rather than creating a note.

Generally the note field could have a pre-defined set of values (dropdown like in streetname quest), which – when selected – avoid the note generation and directly edit the object.

@matkoniecz
Copy link
Member Author

I think that note generation is also a good goal.

With direct edit user taps something in SC.

With note creation user taps something in SC, others review note, look at aerial images or resurvey, make edit, close note...

Whenever possible note generation should be avoided.

@exploide
Copy link
Member

Since almost all house number quests in my area are mistagged garages, I'm wishing for this a long time. But I considered #351 as the covering issue, even if the opening post is somewhat different in contrast to the goals developed later. It's already marked as blocked by the building type quest #25, the currently most upvoted issue.

So 👍 for the solution involving the building type quest.

@westnordost
Copy link
Member

True, #351 is the covering issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants