Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asks for housenumbers of buildings that naturally do not have housenumbers #351

Closed
SomeoneElseOSM opened this issue Jun 25, 2017 · 15 comments
Assignees
Milestone

Comments

@SomeoneElseOSM
Copy link

A lot of StreetComplete notes in the UK (scanned by looking through #osm-gb) are basically "not an answer to the question, because the question was invalid".

Example:
https://www.openstreetmap.org/note/1027000

Also asking for road names for car parks and turning circles etc. makes no sense.

Make it clear when you are asking for e.g. a house number that you want a house number, not a name, or a description, or the colour of the owner's cat, and allow people to say "this question doesn't make sense" (providing you with feedback about what questions work) and not adding an OSM note which will confuse everyone else.

@westnordost
Copy link
Member

westnordost commented Jun 25, 2017

Don't add notes when the question is invalid

Eh? No. This is exactly the reason to add notes, because if a question is invalid, it is very probable that the underlying data is incorrect. Notes were amongst other things especially made for reporting wrong data.

I cleared up the wording (already), see the other issue from you that I commented and closed. Now it should be clear that the note was only written because the user was not able to answer the question. The usual reason why a user is not able to answer a question is because the question was invalid (=based on wrong data).
Naturally, the app cannot detect wrong data, only the surveyor can. And that is why for every question type, it is possible for the surveyor to leave a note.

Also:

  • The app does not ask road names for car parks and turning circles.
  • The app makes clear that it is asking for a house number and not the color of the owner's cat.

If you find that the app is asking wrong questions even though the underyling data is correct, then you are free to report this. The prerequisite of this is however that your allegations are based on correct observations.

@SomeoneElseOSM
Copy link
Author

No, based on the notes added in the UK in the last couple of days an invalid question does not mean wrong data, but a series of incorrect assumptions about real-world data on behalf of the app author. Have a look at the notes feed if you don't believe me.

Taking https://www.openstreetmap.org/note/1027000 again as an example, it is of no benefit to anyone to add that as a note.

Not every building is a house, and not every building has a house number. If you don't control how sensible the notes that this app adds then people will just think "that's a StreetComplete note, it's likely to be rubbish, so I'll just close it". I'm not saying whether that's right or wrong, but it will happen unless you take more responsibility for the notes that you are adding.

@krzyk
Copy link
Contributor

krzyk commented Jun 25, 2017

The app does not ask for housenumbers for all buildings, the list you can find here: https://github.com/westnordost/StreetComplete/blob/master/app/src/main/java/de/westnordost/streetcomplete/quests/housenumber/AddHousenumber.java#L33-L36

Basically it has quite a conservative list to avoid asking for housenumbers for buildings that won't have it.
In your example it asked for the housenumbers because the building is marked as university and it doesn't have housename nor housenumber.

I'm not sure how to avoid that (except by excluding building=university). In my country for university buildings we add housename so I don't have that trouble with StreetComplete (because it excludes such buildings), maybe there should be somekind of exclusion based on name + university zone?

Do you have other examples of wrongly added notes? Right now we can see that universities (or that particular university) in UK are wrongly handled.

@westnordost westnordost reopened this Jun 25, 2017
@westnordost
Copy link
Member

Okay, lets make this issue into this specific problem and create another issue for each "oddly asked question", discuss, and solve.

@westnordost westnordost changed the title Don't add notes when the question is invalid Asks for housenumbers of buildings that naturally do not have housenumbers Jun 25, 2017
@westnordost
Copy link
Member

So, the question is: Can it be assumed that universities (, schools, kindergartens,...) generally have no housenumber? Then, I can simply remove this building type from the white list.

The reality however may be different. I have the impression that it can only be assumed with relative certainty that any buildings within an amenity (at least school, kindergarten, university, perhaps more) do not have housenumbers as long as there is a housenumber on the whole amenity already.
The app does currently not check for that, but it could (with a little more effort). Would it make sense to check that? And if it would, for what other areas should it check that may "override" the housenumbers? Perhaps commercial and industrial landuses?
I know that at least or landuses, it is discouraged to set the housenumber on the whole area instead of the building with the post box/main entrance but I reckon that this may be the way it is mapped now or make more sense for specific cases.

Opinions?

@westnordost
Copy link
Member

@krzyk Or perhaps also exclude buildings with names?

@westnordost westnordost self-assigned this Jun 25, 2017
@westnordost
Copy link
Member

Hm actually, even if I implemented the things I mentioned in my comment yesterday, it wouldn't fix it for the example note you gave because the university campus as a whole also does not have a housenumber.

Two possible solutions come to my mind:

  1. only show quests for universities, schools, kindergartens,.... when the amenity is tagged on the building, meaning the amenity is only in this building.
  2. Offer the user to (instead of leaving a note) answer that the building indeed has no address while acknowledging that the tagged building type is correct. (i.e. not a garage)

@matkoniecz
Copy link
Member

matkoniecz commented Jun 27, 2017

Can it be assumed that universities (, schools, kindergartens,...) generally have no housenumber?

amenity=university object is very unlikely to have an address in Poland. Typical university will include multiple buildings, each with separate address (http://www.openstreetmap.org/way/321067075#map=17/50.08435/19.85276 ). Some may be even scattered across city with multiple buildings and building complexes.

I would expect that building=university would have an address but there are probably cases where this will not be true (quite rare, maybe very rare) with single address for group of buildings.

Schools, kindergartens are more likely to be limited to a single building/building complex with a single address.

@westnordost
Copy link
Member

There is the (so far rarely used) tag https://wiki.openstreetmap.org/wiki/Key:noaddress for the purpose of tagging that a building indeed has no name.

However, the more likely case that a building has no housenumber is that it is wrongly tagged as a i.e. house even though it is a garage etc.

Implementation should be like this:

User can answer "has no housenumber". The app will then pop up a confirmation dialog, asking whether that building is really a XXXXXX. If the user answers "no", the user is prompted to leave a note to explain what kind of building it is instead or even better directly re-tag the building. If the user answers "yes", then and only then it is tagged with noaddress=yes.

This implementation means that it is blocked by the "building type" quest to be implemented.

@westnordost westnordost added the blocked blocked by another issue label Jun 30, 2017
@westnordost westnordost removed their assignment Jun 30, 2017
@SomeoneElseOSM
Copy link
Author

That doesn't address the root of the problem here - the user doesn't get a chance to say that "everything in OSM is just fine" and NOT leave a note and NOT add a rarely used tag that few consumers will anticipate.

@westnordost
Copy link
Member

Yes, that is a general problem in OSM. There is no general distinction between "a property does not exist on an object" and "a property hasn't been determined on an object". But, this is information that is simply necessary to do proper detailed survey for missing data. StreetComplete is only a tool to make it easier to do this kind of survey, the root problem would be just the same without this app.

This is why tags like noaddress=yes, noname=yes etc exist.

However, I do not see any problem with using a "rarely used tag". The fact that few consumers will process it is not any argument for or against any tag. It is not as if any consumer will refuse to work because there is some (for the application) unknown tag on an object.

@westnordost
Copy link
Member

westnordost commented Jan 24, 2018

Ah right, it's blocked. To recap what needs to be done here:

First, wait for #774 to be complete, to have the translations for the common building type names.

Then, add "has no housenumber" as answer-option. This opens a confirmation dialog:
This building is captured as: ... . Is this correct but it simply does not have an own housenumber?
[No (Leave Note)] [Yes]

Clicking No, lets the user leave a note and explain what it is then, clicking yes, adds noaddress=yes to the object.

@westnordost westnordost modified the milestones: v4, v5 Jan 24, 2018
@westnordost westnordost removed this from the v5 milestone Apr 7, 2018
@exploide
Copy link
Member

exploide commented Apr 8, 2018

Clicking No, lets the user leave a note and explain what it is then

When this is blocked by the building type quest, why wouldn't "has no housenumber" option hand over to the building type quest to specify a better value for building=* instead of leaving a note?

@muralito
Copy link

muralito commented Jan 6, 2019

Please do not ask for housenumber of a building when the building has multiple entrances. In these case every address should be in every entrance point.

@matkoniecz
Copy link
Member

Please create a new issue for new issues rather than comment on old closed ones.

It is both more effective and less confusing.

Also, on creating a new issue please mention your country/area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants